use panic-proof type conversion

briskt · briskt · commit 7ce362b2e759 · 2023-07-28T08:01:28.000-06:00
diff --git a/cmd/cli/multiregion/dns.go b/cmd/cli/multiregion/dns.go
@@ -204,11 +204,12 @@ func (d *DnsCommand) getAlbDnsValuesFromTfc(workspaceName string) (values AlbDns
 	}
 
 	for _, item := range outputs.Items {
+		itemValue, _ := item.Value.(string)
 		switch item.Name {
 		case "alb_dns_name":
-			values.external = item.Value.(string)
+			external = itemValue
 		case "internal_alb_dns_name":
-			values.internal = item.Value.(string)
+			internal = itemValue
 		}
 	}
 	return

Original file line number	Diff line number	Diff line change
`@@ -204,11 +204,12 @@ func (d *DnsCommand) getAlbDnsValuesFromTfc(workspaceName string) (values AlbDns`
`204`	`204`	`}`
`205`	`205`
`206`	`206`	`for _, item := range outputs.Items {`
	`207`	`+ itemValue, _ := item.Value.(string)`
`207`	`208`	`switch item.Name {`
`208`	`209`	`case "alb_dns_name":`
`209`		`- values.external = item.Value.(string)`
	`210`	`+ external = itemValue`
`210`	`211`	`case "internal_alb_dns_name":`
`211`		`- values.internal = item.Value.(string)`
	`212`	`+ internal = itemValue`
`212`	`213`	`}`
`213`	`214`	`}`
`214`	`215`	`return`