Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight risk of fields displaying in SiteTree due to scaffolding #657

Open
1 task
GuySartorelli opened this issue Dec 17, 2024 · 0 comments
Open
1 task

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Dec 17, 2024

There is a fairly sizable risk that people have sensitive form fields in their pages that should only be shown if some condition is true, e.g. a permission check.

Right now, if the condition is false it's a no-op and the field won't be displayed.
For CMS 6 a no-op results in the form being scaffolded. Devs will need to either:

  1. flip the condition, so if it's true there's a no-op (or they update the field) and if it's false they explicitly remove the field, or
  2. use the scaffold_cms_fields_settings config to tell framework to explicitly not scaffold the form (and leave the condition as it is)

Acceptance Criteria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant