Fix check whether array is associative

Author: pmishev

Result/DocumentConverter.php

@@ -117,7 +117,7 @@ public function assignArrayToObject(array $array, ObjectInterface $object, array
             } elseif (in_array($propertyMetadata['type'], ['object', 'nested'])) {
                 // ES doesn't mind having either single or multiple objects with the same mapping, but in this bundle we must specifically declare either.
                 // So we must make sure everything works for a 'multiple' definition where we actually have a single object and vice versa.
-                if ($propertyMetadata['multiple'] && key($array[$esField]) !== 0) {
+                if ($propertyMetadata['multiple'] && is_string(key($array[$esField]))) {
                     // field is declared multiple, but actual data is single object
                     $data = [$array[$esField]];
                 } elseif (!$propertyMetadata['multiple'] && key($array[$esField]) === 0) {

Tests/Functional/Result/DocumentConverterTest.php

@@ -4,6 +4,7 @@
 
 use Sineflow\ElasticsearchBundle\Document\MLProperty;
 use Sineflow\ElasticsearchBundle\Exception\DocumentConversionException;
+use Sineflow\ElasticsearchBundle\Result\ObjectIterator;
 use Sineflow\ElasticsearchBundle\Tests\AbstractContainerAwareTestCase;
 use Sineflow\ElasticsearchBundle\Tests\app\fixture\Acme\BarBundle\Document\ObjCategory;
 use Sineflow\ElasticsearchBundle\Tests\app\fixture\Acme\BarBundle\Document\Product;
@@ -156,6 +157,25 @@ public function testAssignArrayToObjectWithEmptyFields()
         $this->assertNull($product->mlInfo);
     }
 
+    public function testAssignArrayToObjectWithEmptyMultipleNestedField()
+    {
+        $converter = $this->getContainer()->get('sfes.document_converter');
+        $metadataCollector = $this->getContainer()->get('sfes.document_metadata_collector');
+
+        $rawDoc = [
+            'related_categories' => [],
+        ];
+
+        $product = new Product();
+        $converter->assignArrayToObject(
+            $rawDoc,
+            $product,
+            $metadataCollector->getDocumentMetadata('AcmeBarBundle:Product')->getPropertiesMetadata()
+        );
+        $this->assertInstanceOf(ObjectIterator::class, $product->relatedCategories);
+        $this->assertSame(0, $product->relatedCategories->count());
+    }
+
     /**
      * @depends testAssignArrayToObjectWithAllFieldsCorrectlySet
      */

Tests/app/config/config_test.yml

@@ -1,6 +1,7 @@
 parameters:
     elasticsearch_hosts:
-        - '127.0.0.1:9200'
+        - '192.168.56.115:9200'
+#        - '127.0.0.1:9200'
 
 # Framework Configuration
 framework: