Fix several silently failing tests (shader-slang#2767)

* Add missing expected.txt for test

* Diagnostics -> StdWriters in render test

* Allow specifying several test prefixes to run

`slang-test -- tests/foo tests/bar`

* Squash warnings in some tests

* Enable gfx debug layer in gfx test util

Makes this issue present consistently: shader-slang#2766

* Allow DebugDevice to return interfaces instantiated by the debugged object

* Check that we actaully have a shader cache for shader cache tests

---------

Co-authored-by: Yong He <yonghe@outlook.com>

Author: expipiplus1

tests/autodiff/high-order-backward-diff-3.slang.expected.txt

@@ -0,0 +1,5 @@
+type: float
+192.000000
+0.000000
+0.000000
+0.000000

tests/bugs/generic-groupshared.slang

@@ -17,7 +17,7 @@ struct S<let n : int>
     int doSomething()
     {
         table<M>(0) = M;
-        return table<M>(0);
+        return int(table<M>(0));
     }
 }
 

tests/compute/half-rw-texture-simple.slang

@@ -25,7 +25,7 @@ RWStructuredBuffer<float> outputBuffer;
 [numthreads(4, 1, 1)]
 void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID)
 {
-    int idx = dispatchThreadID.x;
+    uint idx = dispatchThreadID.x;
 
     float val = 0.0f;
 

tests/compute/half-texture-simple.slang

@@ -35,7 +35,7 @@ RWStructuredBuffer<float> outputBuffer;
 [numthreads(4, 1, 1)]
 void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID)
 {
-    int idx = dispatchThreadID.x;
+    uint idx = dispatchThreadID.x;
     float u = idx * (1.0f / 4);
 
     float val = 0.0f;

tools/gfx-unit-test/gfx-test-util.cpp

@@ -239,6 +239,13 @@ namespace gfx_test
         void* extDescPtr = &extDesc;
         deviceDesc.extendedDescs = &extDescPtr;
 
+        // TODO: We should also set the debug callback
+        // (And in general reduce the differences (and duplication) between
+        // here and render-test-main.cpp)
+#ifdef _DEBUG
+        gfx::gfxEnableDebugLayer();
+#endif
+
         auto createDeviceResult = gfxCreateDevice(&deviceDesc, device.writeRef());
         if (SLANG_FAILED(createDeviceResult))
         {

tools/gfx-unit-test/shader-cache-tests.cpp

@@ -141,7 +141,8 @@ namespace gfx_test
                 [this, func] (IDevice* device, UnitTestContext* ctx)
                 {
                     this->device = device;
-                    device->queryInterface(SLANG_UUID_IShaderCache, (void**)this->shaderCache.writeRef());
+                    SLANG_CHECK_ABORT(SLANG_SUCCEEDED(
+                        device->queryInterface(SLANG_UUID_IShaderCache, (void**)this->shaderCache.writeRef())));
                     func();
                     this->device = nullptr;
                     this->shaderCache = nullptr;

tools/gfx/debug-layer/debug-device.cpp

@@ -26,6 +26,20 @@ using namespace Slang;
 namespace debug
 {
 
+SlangResult DebugDevice::queryInterface(SlangUUID const& uuid, void** outObject) noexcept
+{
+    void* intf = getInterface(uuid);
+    if (intf)
+    {
+        addRef();
+        *outObject = intf;
+        return SLANG_OK;
+    }
+
+    // Fallback to trying to get the interface from the debugged object
+    return baseObject->queryInterface(uuid, outObject);
+}
+
 Result DebugDevice::getNativeDeviceHandles(InteropHandles* outHandles)
 {
     return baseObject->getNativeDeviceHandles(outHandles);

tools/gfx/debug-layer/debug-device.h

@@ -12,7 +12,9 @@ namespace debug
 class DebugDevice : public DebugObject<IDevice>
 {
 public:
-    SLANG_COM_OBJECT_IUNKNOWN_ALL;
+    SlangResult SLANG_MCALL queryInterface(SlangUUID const& uuid, void** outObject) noexcept override;
+    SLANG_COM_OBJECT_IUNKNOWN_ADD_REF;
+    SLANG_COM_OBJECT_IUNKNOWN_RELEASE;
 
 public:
     DebugDevice();

tools/render-test/slang-support.cpp

@@ -10,6 +10,7 @@
 #include <stdio.h>
 
 #include "../../source/core/slang-string-util.h"
+#include "../../source/core/slang-test-tool-util.h"
 
 namespace renderer_test {
 using namespace Slang;
@@ -199,7 +200,7 @@ void ShaderCompilerUtil::Output::reset()
 
     if (auto diagnostics = spGetDiagnosticOutput(slangRequest))
     {
-        fprintf(stderr, "%s", diagnostics);
+        StdWriters::getError().print("%s", diagnostics);
     }
 
     SLANG_RETURN_ON_FAIL(res);

tools/slang-test/options.cpp

@@ -310,18 +310,7 @@ static bool _isSubCommand(const char* arg)
 
 
     // first positional argument is source shader path
-    if (positionalArgs.getCount())
-    {
-        optionsOut->testPrefix = positionalArgs[0];
-        positionalArgs.removeAt(0);
-    }
-
-    // any remaining arguments represent an error
-    if (positionalArgs.getCount() != 0)
-    {
-        stdError.print("unexpected arguments\n");
-        return SLANG_FAIL;
-    }
+    optionsOut->testPrefixes = std::move(positionalArgs);
 
     if (optionsOut->binDir.getLength() == 0)
     {

tools/slang-test/options.h

@@ -52,8 +52,8 @@ struct Options
     // Directory to use when looking for binaries to run. If empty it's not set.
     Slang::String binDir;
 
-    // only run test cases with names that have this prefix. 
-    char const* testPrefix = nullptr;
+    // only run test cases with names have one of these prefixes.
+    Slang::List<const char *> testPrefixes;
 
     // generate extra output (notably: command lines we run)
     bool shouldBeVerbose = false;

tools/slang-test/slang-test-main.cpp

@@ -3900,15 +3900,20 @@ static bool shouldRunTest(
     if(!endsWithAllowedExtension(context, filePath))
         return false;
 
-    if( context->options.testPrefix )
+    if(!context->options.testPrefixes.getCount())
     {
-        if( strncmp(context->options.testPrefix, filePath.begin(), strlen(context->options.testPrefix)) != 0 )
+        return true;
+    }
+
+    // If we have prefixes, it has to match one of them
+    for(auto& p : context->options.testPrefixes)
+    {
+        if(filePath.startsWith(p))
         {
-            return false;
+            return true;
         }
     }
-
-    return true;
+    return false;
 }
 
 void getFilesInDirectory(String directoryPath, List<String>& files)