Fix up parameter block emit for mixed rewriter+IR (shader-slang#316)

* Fix up parameter block emit for mixed rewriter+IR

The basic problem here arose when a parameter block was declared in code that will be lowered via IR, but is referenced from user code that will use the AST-based lowering pass. The type legalization would split up the parameter block, and the AST would refer to the new variables, but it would fail to recognize when those variables represent constant buffers, and thus should get implicit-dereference behavior.

The fix here was just to propagate type information through when creating new AST (pseudo-)expressions to represent IR declarations that were split.

A more complete fix down the road should try to make sure that both the expression emit logic and the declaration-emit logic agree on whether a particular declaration of a parameter block or constant buffer needs to support the "implicit dereference" case or not. I'm leaving that to future work.

With this change, two test cases that had been disabled now pass.

* Fixup: don't do implicit deref for `ParameterBlock` values

Right now the rules for `ParameterBlock` and all other uniform praameter groups needs to be different, but the `isImplicitBaseExpr` logic wasn't taking that into account.

Author: Tim Foley

source/slang/ast-legalize.cpp

@@ -2683,7 +2683,10 @@ struct LoweringVisitor
                 String mangledName = globalVar->mangledName;
                 SLANG_ASSERT(mangledName.Length() != 0);
 
-                return LegalExpr(createUncheckedVarRef(mangledName));
+                RefPtr<Expr> varRef = createUncheckedVarRef(mangledName);
+                varRef->type.type = globalVar->getType()->getValueType();
+
+                return LegalExpr(varRef);
             }
             break;
 

source/slang/emit.cpp

@@ -1410,8 +1410,13 @@ struct EmitVisitor
                 return true;
         }
 
-        // Is the expression referencing a constant buffer?
-        if (auto cbufferType = e->type->As<ConstantBufferType>())
+        // Is the expression referencing a uniform parameter group,
+        // but *not* a `ParameterBlock<T>`?
+        if (auto parameterBlockType = e->type->As<ParameterBlockType>())
+        {
+            return false;
+        }
+        if (auto uniformParameterGroupType = e->type->As<UniformParameterGroupType>())
         {
             return true;
         }

tests/compute/rewriter-parameter-block-complex.hlsl

@@ -1,6 +1,6 @@
 //TEST(compute):HLSL_COMPUTE:-xslang -no-checking
 //TEST(compute):COMPARE_COMPUTE:-xslang -use-ir
-//DISABLED_TEST(compute):HLSL_COMPUTE:-xslang -no-checking -xslang -use-ir
+//TEST(compute):HLSL_COMPUTE:-xslang -no-checking -xslang -use-ir
 
 //TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):dxbinding(0),glbinding(0),out
 

tests/compute/rewriter-parameter-block-complex.hlsl.2.expected.txt

@@ -0,0 +1,4 @@
+1110
+1121
+1132
+1143

tests/compute/rewriter-parameter-block.hlsl

@@ -1,6 +1,6 @@
 //TEST(compute):HLSL_COMPUTE:-xslang -no-checking
 //TEST(compute):COMPARE_COMPUTE:-xslang -use-ir
-//DISABLED_TEST(compute):HLSL_COMPUTE:-xslang -no-checking -xslang -use-ir
+//TEST(compute):HLSL_COMPUTE:-xslang -no-checking -xslang -use-ir
 
 //TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):dxbinding(0),glbinding(0),out
 

tests/compute/rewriter-parameter-block.hlsl.2.expected.txt

@@ -0,0 +1,4 @@
+11110
+11121
+11132
+11143