Fix issue with synthesized __init methods not getting added to witness table (shader-slang#4638)

saipraveenb25 · web-flow · commit b5174b473ffb · 2024-07-16T16:16:02.000-04:00
diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp
@@ -4268,8 +4268,8 @@ namespace Slang
         }
         if (isDefaultInitializableType)
             context->parentDecl->addMember(ctorDecl);
-        else
-            _addMethodWitness(witnessTable, requiredMemberDeclRef, makeDeclRef(ctorDecl));
+        
+        _addMethodWitness(witnessTable, requiredMemberDeclRef, makeDeclRef(ctorDecl));
         
         return true;
     }
diff --git a/tests/compute/assoctype-nested-lookup.slang b/tests/compute/assoctype-nested-lookup.slang
@@ -6,7 +6,7 @@
 //TEST_INPUT:ubuffer(data=[0], stride=4):out,name=outputBuffer
 RWStructuredBuffer<float> outputBuffer;
 
-interface IFoo
+interface IFoo : IDefaultInitializable
 {
     associatedtype Bar : IFoo;
 };

Original file line number	Diff line number	Diff line change
`@@ -4268,8 +4268,8 @@ namespace Slang`
`4268`	`4268`	`}`
`4269`	`4269`	`if (isDefaultInitializableType)`
`4270`	`4270`	`context->parentDecl->addMember(ctorDecl);`
`4271`		`- else`
`4272`		`- _addMethodWitness(witnessTable, requiredMemberDeclRef, makeDeclRef(ctorDecl));`
	`4271`	`+`
	`4272`	`+ _addMethodWitness(witnessTable, requiredMemberDeclRef, makeDeclRef(ctorDecl));`
`4273`	`4273`
`4274`	`4274`	`return true;`
`4275`	`4275`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`//TEST_INPUT:ubuffer(data=[0], stride=4):out,name=outputBuffer`
`7`	`7`	`RWStructuredBuffer<float> outputBuffer;`
`8`	`8`
`9`		`-interface IFoo`
	`9`	`+interface IFoo : IDefaultInitializable`
`10`	`10`	`{`
`11`	`11`	`associatedtype Bar : IFoo;`
`12`	`12`	`};`