Skip to content

Commit eb4ee72

Browse files
aleino-nvcsyonghe
andauthored
Enable WGPU texture sampling test (shader-slang#5617)
* Limit number of MIP levels on 1d textures to be 1 This avoids running into a WebGPU limitation, and helps to address issue shader-slang#4943. * Update Slang-RHI to get WGPU fixes * Enable WGPU texture sampling test This helps to address issue shader-slang#4943. --------- Co-authored-by: Yong He <yonghe@outlook.com>
1 parent 00765c3 commit eb4ee72

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

external/slang-rhi

tests/compute/texture-sampling-no-1d-arrays.slang

+3-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
//TEST(compute):COMPARE_RENDER_COMPUTE: -shaderobj -output-using-type -mtl
44

55

6-
//TEST_INPUT: Texture1D(size=4, content = one):name=t1D
6+
// WebGPU only supports 1 MIP level for 1d textures
7+
// https://www.w3.org/TR/webgpu/#abstract-opdef-maximum-miplevel-count
8+
//TEST_INPUT: Texture1D(size=4, content = one, mipMaps=1):name=t1D
79
//TEST_INPUT: Texture2D(size=4, content = one):name=t2D
810
//TEST_INPUT: Texture3D(size=4, content = one):name=t3D
911
//TEST_INPUT: TextureCube(size=4, content = one):name=tCube
@@ -12,9 +14,6 @@
1214
//TEST_INPUT: Sampler:name=samplerState
1315
//TEST_INPUT: ubuffer(data=[0 0 0 0], stride=4):out,name=outputBuffer
1416

15-
// There are still some issues to fix in RHI, see issue #4943
16-
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu
17-
1817
Texture1D t1D;
1918
Texture2D t2D;
2019
Texture3D t3D;

0 commit comments

Comments
 (0)