Skip to content

Commit ff9437e

Browse files
ArielG-NVcsyonghe
andauthored
Implement non member function atomic texture support (shader-slang#4544)
* Implement non member function atomic texture support texture_buffer and texture1d Fixes: shader-slang#4538 Related to: shader-slang#4291, fixes `tests/compute/atomics-buffer.slang` Texture objects cannot use `__getMetalAtomicRef` to cast objects into atomic value type. [Texture objects mandate use of member functions](https://developer.apple.com/metal/Metal-Shading-Language-Specification.pdf#Texture%20Functions). The implementation is as follows: * We can detect texture object usage through checking for an `IRImageSubscript` Operation. `__isTextureAccess()` was added to evaluate if we have an `IRImageSubscript` operation at compile time (before `static_assert`). `__isTextureAccess()` only checks if we are targeting Metal. * We have all parameter data needed to call a texture atomic function embedded inside `IRImageSubscript`. `__extractTextureFromTextureAccess()` and `__extractCoordFromTextureAccess()` was added to extract this data for use with Metal atomics. Note: * Metal documentation has various incorrect details (function names) * Since we currently hardcode metal versions for compiling, the Metal compiler version was changed to target `Metal 3.1` (`slang-gcc-compiler-util.cpp`) * textures do not permit atomic float operations * add fallthrough attribute + fix bug with 'exchange instead of xor' + fix warning bug * incorrect function name fix * missing filecheck * disable atomics-buffer.slang compute test since GFX issue causing it to fail * Array support for metal interlockedAtomic and proper verification of texture with interlockedAtomic functions * Array support for metal interlockedAtomic * proper verification of texture with interlockedAtomic functions note: had to seperate many functions to allow forceInlining to run * missing getOperand(0) * push atomic fix for metal * fix atomic syntax for metal and hlsl emitting extra brackets (breaks tests) * test changes and meta changes 1. max is 8 rw textures with metal because Metal has this limit. Split up tests to not hit this limit 2. added back `[0]`...,`T` to test since this legalizes metal atomic intrinsic * macro'ify some of the atomic code 1. addresses review 2. makes code easier to modify in the future (rather than sifting through 1000 lines we can just look at ~10-30 * fix test 'check' * missing float support due to macro * add functions macro generates, `InternalAtomicOperationInfo` --------- Co-authored-by: Yong He <yonghe@outlook.com>
1 parent a08ccfa commit ff9437e

17 files changed

+1345
-694
lines changed

source/compiler-core/slang-gcc-compiler-util.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ static SlangResult _parseGCCFamilyLine(SliceAllocator& allocator, const UnownedS
476476

477477
if (targetDesc.payload == ArtifactDesc::Payload::MetalAIR)
478478
{
479-
cmdLine.addArg("-std=macos-metal2.3");
479+
cmdLine.addArg("-std=metal3.1");
480480
}
481481

482482
// Our generated code very often casts between dissimilar types with the

0 commit comments

Comments
 (0)