Add JSON_MERGE_PATH method into mysql predicate helper

Author: snezhig

src/Command/ProductInsertCompare.php

@@ -26,10 +26,12 @@ public function __construct(
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $items = [
-            ['ext_props' => 0, 'batch' => false, 'count' => 5],
+            ['ext_props' => 0, 'batch' => false, 'count' => 3],
             ['ext_props' => 0, 'batch' => true, 'count' => 5],
-            ['ext_props' => 4000, 'batch' => false, 'count' => 5],
+            ['ext_props' => 0, 'batch' => true, 'count' => 1000],
+            ['ext_props' => 4000, 'batch' => false, 'count' => 3],
             ['ext_props' => 4000, 'batch' => true, 'count' => 5],
+            ['ext_props' => 4000, 'batch' => true, 'count' => 1000],
         ];
         $results = [];
 
@@ -98,10 +100,7 @@ private function createData(int $count, int $propsCount = 0): array
             $properties = [];
 
             for ($pIndex = 1; $pIndex <= $propsCount; $pIndex++) {
-                $properties["p_{$pIndex}"] = $faker->randomElement([
-                    $faker->randomFloat(2, 1, 100000),
-                    $faker->numberBetween(1, 10000),
-                    $faker->word
+                $properties["p_{$pIndex}"] = $faker->randomElement([''
                 ]);
             }
 

src/Helper/MysqlPredicateHelper.php

@@ -3,6 +3,7 @@
 namespace App\Helper;
 
 use Doctrine\Common\Collections\ArrayCollection;
+use JsonException;
 
 class MysqlPredicateHelper extends AbstractSqlPredicateHelper
 {
@@ -61,21 +62,34 @@ public function getWhereCollection(): ArrayCollection
         ]));
     }
 
-    public function createJsonSetPredicate(array $data): string
+    /**
+     * @throws JsonException
+     */
+    public function createJsonUpdatePredicate(array $data): string
     {
-        $format = sprintf(
-            'JSON_SET(properties, %s)',
-            implode(',',
-                array_fill(0, count($data) * 2, '%s'))
-        );
-        $flatData = [];
-        foreach ($data as $key => $value) {
-            $flatData[] = "'$.$key'";
-            $flatData[] = match (gettype($value)) {
+        return match (count($data)) {
+            1 => $this->createJsonSetPredicate(array_key_first($data), current($data)),
+            default => $this->createJsonMergePatch($data)
+        };
+    }
+
+    private function createJsonSetPredicate(string $key, float|int|string $value): string
+    {
+        return sprintf(
+            "JSON_SET(properties, '$.%s', %s)",
+            $key,
+            match (gettype($value)) {
                 'string' => sprintf('"%s"', $value),
                 default => $value,
-            };
-        }
-        return sprintf($format, ...$flatData);
+            }
+        );
+    }
+
+    private function createJsonMergePatch(array $data): string
+    {
+        return sprintf(
+            "JSON_MERGE_PATCH(properties, '%s')",
+            json_encode($data, JSON_THROW_ON_ERROR)
+        );
     }
 }

src/Helper/PostgresqlPredicateHelper.php

@@ -3,6 +3,7 @@
 namespace App\Helper;
 
 use Doctrine\Common\Collections\ArrayCollection;
+use JsonException;
 
 class PostgresqlPredicateHelper extends AbstractSqlPredicateHelper
 {
@@ -64,7 +65,7 @@ public function getWhereCollection(): ArrayCollection
         ]));
     }
 
-    public function createJsonSetPredicate(array $data): string
+    public function createJsonUpdatePredicate(array $data): string
     {
         return match (count($data)) {
             1 => $this->createJsonSet(array_key_first($data), current($data)),
@@ -84,6 +85,9 @@ private function createJsonSet(string $key, string|int|float $value): string
         );
     }
 
+    /**
+     * @throws JsonException
+     */
     private function createJsonMerge(array $data): string
     {
         return sprintf("properties || '%s'", json_encode($data, JSON_THROW_ON_ERROR));

src/Helper/SqlPredicateHelper.php

@@ -15,5 +15,5 @@ public function getSelect(): array;
 
     public function getValueSetting(): SqlCompareValueSetting;
 
-    public function createJsonSetPredicate(array $data): string;
+    public function createJsonUpdatePredicate(array $data): string;
 }

src/Service/ProductSqlUpdateService.php

@@ -26,7 +26,7 @@ public function setPredicateHelper(SqlPredicateHelper $helper): self
 
     public function setPropertyKeys(array $data, int $limit = 0): DebugStack
     {
-        $predicate = $this->helper->createJsonSetPredicate($data);
+        $predicate = $this->helper->createJsonUpdatePredicate($data);
         $manager = $this->registry->getManager();
         /**@var Connection $connection*/
         $connection = $this->registry->getConnection($this->helper->getConnectionName());

tests/Unit/SqlPredicteHelper/MysqlPredicateHelperTest.php

@@ -12,7 +12,7 @@ class MysqlPredicateHelperTest extends AbstractSqlPredicateHelperTest
 {
     public function testCreateJsonSetPredicate(): void
     {
-        $predicate = $this->helper->createJsonSetPredicate([
+        $predicate = $this->helper->createJsonUpdatePredicate([
             'int_string' => '32',
             'int'        => 23,
             'string'     => 'string_value',

tests/Unit/SqlPredicteHelper/PostgresqlPredicateHelperTest.php

@@ -13,7 +13,7 @@ class PostgresqlPredicateHelperTest extends AbstractSqlPredicateHelperTest
      */
     public function testCreateJsonSetPredicateSingle(array $value)
     {
-        $predicate = $this->helper->createJsonSetPredicate($value);
+        $predicate = $this->helper->createJsonUpdatePredicate($value);
         $sql = $this->createUpdatePropertySql($predicate);
         $this->explain($sql);
         $this->addToAssertionCount(1);