Add catch for feature errors, fix inline feature and alias

Author: snezhig

main.ts

@@ -1,6 +1,6 @@
 import "reflect-metadata";
 
-import { AppExt, CachedMetadata, Modal, Plugin } from "obsidian";
+import { AppExt, CachedMetadata, Modal, Notice, Plugin } from "obsidian";
 import { SettingsEvent, SettingsType } from "@src/Settings/SettingsType";
 import SettingsTab from "@src/Settings/SettingsTab";
 import Storage from "@src/Storage/Storage";
@@ -152,7 +152,13 @@ export default class MetaTitlePlugin extends Plugin implements PluginInterface {
         }
 
         for (const [id, state] of states) {
-            this.fc.toggle(id, state as boolean);
+            try {
+                this.fc.toggle(id, state as boolean);
+            } catch (e) {
+                //TODO: refactor
+                this.fc.toggle(id, false);
+                new Notice(e);
+            }
         }
     }
 

src/Feature/Alias/Alias.ts

@@ -47,7 +47,7 @@ export default class Alias {
     }
 
     private getPossibleKeys(): string[] {
-        return ["alias", "aliases"];
+        return ["aliases", "alias"];
     }
 
     private modify(alias: string | string[]): void {

src/Feature/InlineTitle/InlineTitleManager.ts

@@ -98,7 +98,7 @@ export class InlineTitleManager extends AbstractManager {
         const id = this.getTitleElId(view);
         const original = view.inlineTitleEl;
         const { created } = this.fakeTitleElementService.getOrCreate({ original, title, id, events: ["click"] });
-        if (created) {
+        if (created && !original.isActiveElement()) {
             this.fakeTitleElementService.setVisible(id, true);
         }
         return id;

src/Utils/FakeTitleElementService.ts

@@ -88,6 +88,7 @@ export default class FakeTitleElementService {
         }
 
         container.insertBefore(element, original);
+        element.hidden = true;
 
         return { created: true, element };
     }

test/unit/Feature/Alias/Alias.spec.ts

@@ -66,15 +66,15 @@ describe("Test mutation", () => {
     });
 });
 describe("Test mutation of empty object", () => {
-    const data: { alias?: any } = {};
+    const data: { aliases?: any } = {};
     const alias = new Alias(data);
     test("Should set `foo` as a value and createNamed new key", () => {
         expect(alias.getKey()).toBeNull();
         expect(alias.getValue()).toBeNull();
         alias.setValue("foo");
-        expect(alias.getKey()).toEqual("alias");
+        expect(alias.getKey()).toEqual("aliases");
         expect(alias.getValue()).toEqual("foo");
-        expect(data.alias).toEqual("foo");
+        expect(data.aliases).toEqual("foo");
     });
     test("Should restore data", () => {
         alias.restore();