Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(frontend): cannot generate reputation proof while rep < 0 #626

Open
kittybest opened this issue Jan 14, 2025 · 1 comment
Open

Bug(frontend): cannot generate reputation proof while rep < 0 #626

kittybest opened this issue Jan 14, 2025 · 1 comment
Assignees
Labels
bug Something isn't working circuit frontend

Comments

@kittybest
Copy link
Collaborator

kittybest commented Jan 14, 2025

Describe the bug
User cannot generate reputation proof (or epoch key proof) when having negative reputation.

To Reproduce
Steps to reproduce the behavior:

  1. Sign up and leave a post
  2. report your own post
  3. make other adjudicate that either agree or disagree (each way causes negative reputation)
  4. click the "daily check in"
  5. click on report detail
  6. both above conditions would fail (cannot check in, cannot see report detail)

Expected behavior
Even user having negative reputation, they could pass the proof check or circuit.

Screenshots
see comments in PR #625

image
image

Additional Notes

replied by Vivi (in DC):
這個表示 data[1] >= data[0] + max_rep 沒有成立
所以可能 data[0], data[1] 沒有被更新(!?
要UST 或waitForSync之類的
還有 data 跟 provableData 不一樣 😿
這裡能prove的是 provableData

replied by Arthur (in DC):
現在每日 checkin 都已經有做 UST 了~

@github-actions github-actions bot added bug Something isn't working circuit frontend labels Jan 14, 2025
@vivianjeng
Copy link
Contributor

  • 每日簽到檢查provableData
  • 看report detail 不用檢查rep genProveReputationProof({}) (不用帶參數進去)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working circuit frontend
Projects
None yet
Development

No branches or pull requests

3 participants