Changed strategic logistic loss to avoid adding a second gaming stage (#22)

* Changed strategic logistic loss to avoid adding a second gaming stage

* Renamed strategic_logistic_loss

Author: yoshavit

whynot/simulators/credit/__init__.py

@@ -6,7 +6,7 @@
     dynamics,
     Intervention,
     simulate,
-    strategic_logistic_loss,
+    logistic_loss,
     State,
 )
 

whynot/simulators/credit/environments.py

@@ -9,14 +9,14 @@
     Config,
     Intervention,
     simulate,
-    strategic_logistic_loss,
+    logistic_loss,
     State,
 )
 
 
 def compute_reward(intervention, state, config):
     """Compute the reward based on the observed state and choosen intervention."""
-    return strategic_logistic_loss(
+    return logistic_loss(
         config, state.features, state.labels, intervention.updates["theta"],
     )
 

whynot/simulators/credit/simulator.py

@@ -104,17 +104,14 @@ def __init__(self, time=30, **kwargs):
         super(Intervention, self).__init__(Config, time, **kwargs)
 
 
-def strategic_logistic_loss(config, features, labels, theta):
+def logistic_loss(config, features, labels, theta):
     """Evaluate the performative loss for logistic regression classifier."""
 
     config = config.update(Intervention(theta=theta))
 
-    # Compute adjusted data
-    strategic_features = agent_model(features, config)
-
     # compute log likelihood
-    num_samples = strategic_features.shape[0]
-    logits = strategic_features @ config.theta
+    num_samples = features.shape[0]
+    logits = features @ config.theta
     log_likelihood = (1.0 / num_samples) * np.sum(
         -1.0 * np.multiply(labels, logits) + np.log(1 + np.exp(logits))
     )