You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The BTNode in the BinarySearchTreeImplementation has non-private members along with their getter & setter methods.
Getters & Setters are actually required in case of private fields.But in case of non-private members they are not required as we can access them directly.
I suggest either to make the corresponding fields private or remove the getters & setters.Can I raise a pull request for it?
The text was updated successfully, but these errors were encountered:
I know I am too late. This type of problem like BinarySearchTreeImplementation is rare and very informative. Please raise a pull request. I have assigned it to you.
The BTNode in the BinarySearchTreeImplementation has non-private members along with their getter & setter methods.
Getters & Setters are actually required in case of private fields.But in case of non-private members they are not required as we can access them directly.
I suggest either to make the corresponding fields private or remove the getters & setters.Can I raise a pull request for it?
The text was updated successfully, but these errors were encountered: