Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope resolution for fields in BST Node #117

Open
digambar-t7 opened this issue Oct 14, 2022 · 1 comment
Open

Scope resolution for fields in BST Node #117

digambar-t7 opened this issue Oct 14, 2022 · 1 comment
Assignees

Comments

@digambar-t7
Copy link

The BTNode in the BinarySearchTreeImplementation has non-private members along with their getter & setter methods.
Getters & Setters are actually required in case of private fields.But in case of non-private members they are not required as we can access them directly.

I suggest either to make the corresponding fields private or remove the getters & setters.Can I raise a pull request for it?

@sourav2002
Copy link
Owner

I know I am too late. This type of problem like BinarySearchTreeImplementation is rare and very informative. Please raise a pull request. I have assigned it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants