Fixed flea offers not reducing quantity after purchase - TODO - consider refactor of how quantity is handled across ragfair code

Author: Chomp

project/src/controllers/TradeController.ts

@@ -170,6 +170,9 @@ export class TradeController {
             scheme_items: requestOffer.items,
         };
 
+        // Reduce flea offer quanity
+        fleaOffer.quantity -= requestOffer.count;
+
         this.tradeHelper.buyItem(pmcData, buyData, sessionId, this.traderConfig.purchasesAreFoundInRaid, output);
     }
 

project/src/helpers/RagfairOfferHelper.ts

@@ -550,10 +550,12 @@ export class RagfairOfferHelper {
         if (offer.sellInOnePiece || boughtAmount === offerStackCount) {
             this.deleteOfferById(offerOwnerSessionId, offer._id);
         } else {
+            // Partial purchase
             const offerRootItem = offer.items[0];
 
             // Reduce offer root items stack count
             offerRootItem.upd.StackObjectsCount -= boughtAmount;
+            offer.quantity -= boughtAmount;
         }
 
         // Assemble payment to send to seller now offer was purchased

project/src/helpers/TradeHelper.ts

@@ -98,6 +98,9 @@ export class TradeHelper {
                         traderId: buyRequestData.tid,
                     };
                     this.traderHelper.addTraderPurchasesToPlayerProfile(sessionID, itemPurchaseDetails, itemPurchased);
+
+                    // Update offer quantity
+                    offerWithItem.quantity -= buyCount;
                 }
             };
 

project/src/services/RagfairOfferService.ts

@@ -138,6 +138,7 @@ export class RagfairOfferService {
     public removeOfferStack(offerId: string, amount: number): void {
         const offer = this.ragfairOfferHandler.getOfferById(offerId);
         if (offer) {
+            offer.quantity -= amount;
             offer.items[0].upd.StackObjectsCount -= amount;
             if (offer.items[0].upd.StackObjectsCount <= 0) {
                 this.processStaleOffer(offer);