Skip to content

Latest commit

 

History

History
37 lines (27 loc) · 2.8 KB

contributing.md

File metadata and controls

37 lines (27 loc) · 2.8 KB

Contributing

Hey! You're thinking about contributing? That's awesome! You're awesome.

Here's a few things you should know before you submit your PR:

  1. Bouncy Ball is a curation, not a collection. Not every technique makes sense in this format. For example, submissions using immature libraries, unstable APIs, or slight variations on existing techniques probably wouldn't be accepted.
  2. New animation code should not require a build/compile step. For example, you'll want to use CSS instead of SCSS and browser-compatible JavaScript instead of Typescript.
  3. Write concise, clean code. For style recommendations, check out AirBnB's JavaScript Styleguide.
  4. Any new animation should work on the demo page and be visually indistinguishable from existing animations (except for the color of the ball).
  5. Please test your animation across modern browsers. If some browsers don't support the animation, ensure the incompatibilty message is displayed.
  6. The browser compatibility requirement for the bouncy-ball site itself is modern browsers (Edge, Chrome, Firefox, and Safari).

When in doubt on how to organize your example, start by copying the examples/template folder and using it as a base. You can look at the structure of existing examples for reference.

Development Workflow

  1. Clone the project down to your computer.
  2. From the project folder, run npm ci in your terminal.
  3. Start a local static server with npm start in your terminal and visit the URL given by the output to see the site.
  4. Make file changes, and refresh to see them updated.

Updating Dependencies

  1. Animation examples using a library have a downloaded copy of the library in their folder. To update it, replace it with a newer version of the file and rename it accordingly.
  2. Other JavaScript dependencies are declared in package.json. They use esinstall to generate ES6 modules bundles which are saved in site/web_modules. To update them:
    • Install the updated version of the package: npm i package@x.x.x
    • Rebuild the dependencies with esinstall: npm run build
    • Test the functionality and check the files into version control.
  3. Dependencies with custom builds are kept in site/vendor_custom. To update these, browse to the URL at the top of the file, regenerate the code snippet, and paste it over the existing snippet.

Contribution Workflow

  1. Fork and clone the repo.
  2. Make your changes on a feature-branch.
  3. Submit a Pull Request to the main branch.