controllerserver: enable leader election for HA

- enable leader-election for the controller server to ensure
  high availability
- upgrade the sidecar versions to the latest ones

Signed-off-by: Xin Yang <Xin.Yang@arm.com>
Change-Id: Ia0f0d3054750e0dcb3cd1315d743de89c69e190a
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk-csi/+/19674
Reviewed-by: Kamil Godzwon <kamilx.godzwon@intel.com>
Reviewed-by: Antti Kervinen <antti.kervinen@intel.com>
Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
Reviewed-by: Yibo Cai <yibo.cai@arm.com>

Author: xinydev

README.md

@@ -13,7 +13,7 @@ for detailed introduction.
 
 ## Supported platforms
 
-This plugin conforms to [CSI Spec v1.6.0](https://github.com/container-storage-interface/spec/blob/v1.6.0/spec.md).
+This plugin conforms to [CSI Spec v1.7.0](https://github.com/container-storage-interface/spec/blob/v1.7.0/spec.md).
 It is currently developed and tested only on Kubernetes.
 
 This plugin supports `x86_64` and `Arm64` architectures.

charts/spdk-csi/templates/controller-rbac.yaml

@@ -49,6 +49,9 @@ rules:
 - apiGroups: ["storage.k8s.io"]
   resources: ["volumeattachments"]
   verbs: ["get", "list", "watch"]
+- apiGroups: ["coordination.k8s.io"]
+  resources: ["leases"]
+  verbs: ["get", "watch", "list", "delete", "update", "create"]
 
 ---
 kind: ClusterRoleBinding

charts/spdk-csi/templates/controller.yaml

@@ -30,7 +30,8 @@ spec:
         - "--csi-address=unix:///csi/csi-provisioner.sock"
         - "--timeout=30s"
         - "--retry-interval-start=500ms"
-        - "--leader-election=false"
+        - "--leader-election=true"
+        - "--leader-election-namespace={{ .Release.Namespace }}"
         volumeMounts:
         - name: socket-dir
           mountPath: /csi
@@ -40,7 +41,8 @@ spec:
         args:
         - "--v=5"
         - "--csi-address=unix:///csi/csi-provisioner.sock"
-        - "--leader-election=false"
+        - "--leader-election=true"
+        - "--leader-election-namespace={{ .Release.Namespace }}"
         volumeMounts:
         - name: socket-dir
           mountPath: /csi

charts/spdk-csi/values.yaml

@@ -8,16 +8,16 @@ image:
     tag: canary
     pullPolicy: Never
   csiProvisioner:
-    repository: k8s.gcr.io/sig-storage/csi-provisioner
-    tag: v2.0.2
+    repository: registry.k8s.io/sig-storage/csi-provisioner
+    tag: v3.5.0
     pullPolicy: IfNotPresent
   csiAttacher:
-    repository: k8s.gcr.io/sig-storage/csi-attacher
-    tag: v3.0.0
+    repository: registry.k8s.io/sig-storage/csi-attacher
+    tag: v4.3.0
     pullPolicy: IfNotPresent
   nodeDriverRegistrar:
-    repository: k8s.gcr.io/sig-storage/csi-node-driver-registrar
-    tag: v2.0.1
+    repository: registry.k8s.io/sig-storage/csi-node-driver-registrar
+    tag: v2.8.0
     pullPolicy: IfNotPresent
 
 serviceAccount:

deploy/kubernetes/controller-rbac.yaml

@@ -50,6 +50,9 @@ rules:
 - apiGroups: ["storage.k8s.io"]
   resources: ["volumeattachments"]
   verbs: ["get", "list", "watch"]
+- apiGroups: ["coordination.k8s.io"]
+  resources: ["leases"]
+  verbs: ["get", "watch", "list", "delete", "update", "create"]
 
 ---
 kind: ClusterRoleBinding

deploy/kubernetes/controller.yaml

@@ -21,37 +21,35 @@ spec:
       hostNetwork: true
       containers:
       - name: spdkcsi-provisioner
-        image: k8s.gcr.io/sig-storage/csi-provisioner:v2.0.2
+        image: registry.k8s.io/sig-storage/csi-provisioner:v3.5.0
         imagePullPolicy: "IfNotPresent"
         args:
         - "--v=5"
         - "--csi-address=unix:///csi/csi-provisioner.sock"
         - "--timeout=30s"
         - "--retry-interval-start=500ms"
-        - "--leader-election=false"
+        - "--leader-election=true"
         volumeMounts:
         - name: socket-dir
           mountPath: /csi
       - name: spdkcsi-snapshotter
-        image: k8s.gcr.io/sig-storage/csi-snapshotter:v3.0.3
+        image: registry.k8s.io/sig-storage/csi-snapshotter:v6.2.2
         args:
         - "--csi-address=unix:///csi/csi-provisioner.sock"
         - "--v=5"
         - "--timeout=150s"
-        - "--leader-election=false"
+        - "--leader-election=true"
         imagePullPolicy: "IfNotPresent"
-        securityContext:
-          privileged: true
         volumeMounts:
         - name: socket-dir
           mountPath: /csi
       - name: spdkcsi-attacher
-        image: k8s.gcr.io/sig-storage/csi-attacher:v3.0.0
+        image: registry.k8s.io/sig-storage/csi-attacher:v4.3.0
         imagePullPolicy: "IfNotPresent"
         args:
         - "--v=5"
         - "--csi-address=unix:///csi/csi-provisioner.sock"
-        - "--leader-election=false"
+        - "--leader-election=true"
         volumeMounts:
         - name: socket-dir
           mountPath: /csi

deploy/kubernetes/node.yaml

@@ -21,7 +21,7 @@ spec:
       - name: spdkcsi-registrar
         securityContext:
           privileged: true
-        image: k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.0.1
+        image: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0
         imagePullPolicy: "IfNotPresent"
         args:
         - "--v=5"

go.mod

@@ -3,7 +3,7 @@ module github.com/spdk/spdk-csi
 go 1.19
 
 require (
-	github.com/container-storage-interface/spec v1.6.0
+	github.com/container-storage-interface/spec v1.7.0
 	github.com/google/uuid v1.3.0
 	github.com/kubernetes-csi/csi-lib-utils v0.7.0
 	github.com/onsi/gomega v1.19.0

go.sum

@@ -91,8 +91,8 @@ github.com/cncf/xds/go v0.0.0-20210922020428-25de7278fc84/go.mod h1:eXthEFrGJvWH
 github.com/cncf/xds/go v0.0.0-20211001041855-01bcc9b48dfe/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
 github.com/cncf/xds/go v0.0.0-20211011173535-cb28da3451f1/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
 github.com/container-storage-interface/spec v1.1.0/go.mod h1:6URME8mwIBbpVyZV93Ce5St17xBiQJQY67NDsuohiy4=
-github.com/container-storage-interface/spec v1.6.0 h1:vwN9uCciKygX/a0toYryoYD5+qI9ZFeAMuhEEKO+JBA=
-github.com/container-storage-interface/spec v1.6.0/go.mod h1:8K96oQNkJ7pFcC2R9Z1ynGGBB1I93kcS6PGg3SsOk8s=
+github.com/container-storage-interface/spec v1.7.0 h1:gW8eyFQUZWWrMWa8p1seJ28gwDoN5CVJ4uAbQ+Hdycw=
+github.com/container-storage-interface/spec v1.7.0/go.mod h1:JYuzLqr9VVNoDJl44xp/8fmCOvWPDKzuGTwCoklhuqk=
 github.com/cpuguy83/go-md2man/v2 v2.0.1/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o=
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/creack/pty v1.1.11/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=