Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pageable inconsistent with hateoas pagemetadata int/long #3135

Open
pcornelissen opened this issue Aug 8, 2024 · 0 comments
Open

Pageable inconsistent with hateoas pagemetadata int/long #3135

pcornelissen opened this issue Aug 8, 2024 · 0 comments
Assignees
Labels
status: waiting-for-triage An issue we've not yet triaged

Comments

@pcornelissen
Copy link

I just noticed that the spring data interface pageable uses int for page number and page size, but the PageMetaData from the PagedModel in spring hateoas uses long for size, totalElements, totalPages and number.

This makes in unnecessary hard to combine both paging approaches within the spring libs.
In terms of expected values it won't be a problem to simply cast, one to the other, because you seldom would have more pages than max_int.
Nevertheless, this would be good to harmonize.

This is why I created the issue here, because it should be better to upgrade ints to long, than reduce the long to int. (even though it should hopefully not lead to errors)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 8, 2024
@mp911de mp911de transferred this issue from spring-projects/spring-data-jpa Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

No branches or pull requests

3 participants