Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some libraries in lib are server-only #1774

Open
riccardobl opened this issue Dec 29, 2024 · 1 comment
Open

Some libraries in lib are server-only #1774

riccardobl opened this issue Dec 29, 2024 · 1 comment
Labels
backburner postpone consideration of ticket

Comments

@riccardobl
Copy link
Member

Follow-up of #1727 (comment)
I am listing here the libraries in lib/ that cannot be used in the client because they depend on the Node environment.

  • lib/proxy.js : imports node https and http
  • lib/cln.js : imports lib/proxy
  • lib/rss.js imports api/ssrApollo
  • lib/lnd.js needs access to the filesystem

@huumn suggested that this code can go under api/lib.

Refactoring now would cause conflicts with the pending PRs, so I am using this issue to track them for a later time when there will be fewer pending changes.

@riccardobl riccardobl added the backburner postpone consideration of ticket label Dec 29, 2024
@huumn
Copy link
Member

huumn commented Dec 29, 2024

I plan on spending most of my January paying off some of our technical debt. Reorging files should definitely be part of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backburner postpone consideration of ticket
Projects
None yet
Development

No branches or pull requests

2 participants