ZUGFeRD - BG-27 & BG-28 not processed

[quotschmacher]

I have the following (shortened) invoice:

<?xml version="1.0" encoding="utf-8"?>
<rsm:CrossIndustryInvoice xmlns:a="urn:un:unece:uncefact:data:standard:QualifiedDataType:100" xmlns:rsm="urn:un:unece:uncefact:data:standard:CrossIndustryInvoice:100" xmlns:qdt="urn:un:unece:uncefact:data:standard:QualifiedDataType:100" xmlns:ram="urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:100" xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:udt="urn:un:unece:uncefact:data:standard:UnqualifiedDataType:100">
  <rsm:ExchangedDocumentContext>
    <ram:GuidelineSpecifiedDocumentContextParameter>
      <ram:ID>urn:cen.eu:en16931:2017</ram:ID>
    </ram:GuidelineSpecifiedDocumentContextParameter>
  </rsm:ExchangedDocumentContext>
  <rsm:ExchangedDocument>
  </rsm:ExchangedDocument>
  <rsm:SupplyChainTradeTransaction>
    <ram:IncludedSupplyChainTradeLineItem>
      <ram:AssociatedDocumentLineDocument>
        <ram:LineID>5</ram:LineID>
      </ram:AssociatedDocumentLineDocument>
      <ram:SpecifiedTradeProduct>
        <ram:Name>Position</ram:Name>
      </ram:SpecifiedTradeProduct>
      <ram:SpecifiedLineTradeAgreement>
        <ram:GrossPriceProductTradePrice>
          <ram:ChargeAmount>57.00</ram:ChargeAmount>
        </ram:GrossPriceProductTradePrice>
        <ram:NetPriceProductTradePrice>
          <ram:ChargeAmount>57.00</ram:ChargeAmount>
        </ram:NetPriceProductTradePrice>
      </ram:SpecifiedLineTradeAgreement>
      <ram:SpecifiedLineTradeDelivery>
        <ram:BilledQuantity unitCode="HUR">2.5000</ram:BilledQuantity>
      </ram:SpecifiedLineTradeDelivery>
      <ram:SpecifiedLineTradeSettlement>
        <ram:ApplicableTradeTax>
          <ram:TypeCode>VAT</ram:TypeCode>
          <ram:CategoryCode>S</ram:CategoryCode>
          <ram:RateApplicablePercent>19.00</ram:RateApplicablePercent>
        </ram:ApplicableTradeTax>
        <ram:SpecifiedTradeAllowanceCharge>
          <ram:ChargeIndicator>
            <udt:Indicator>false</udt:Indicator>
          </ram:ChargeIndicator>
          <ram:ActualAmount>3.56</ram:ActualAmount>
          <ram:ReasonCode>95</ram:ReasonCode>
          <ram:Reason>Rabatt</ram:Reason>
        </ram:SpecifiedTradeAllowanceCharge>
        <ram:SpecifiedTradeSettlementLineMonetarySummation>
          <ram:LineTotalAmount>138.94</ram:LineTotalAmount>
        </ram:SpecifiedTradeSettlementLineMonetarySummation>
      </ram:SpecifiedLineTradeSettlement>
    </ram:IncludedSupplyChainTradeLineItem>
</rsm:CrossIndustryInvoice>

The allowance is not processed ( https://portal3.gefeg.com/projectdata/invoice/deliverables/installed/publishingproject/zugferd%202.1.1%20-%20facturx%201.0.05/en%2016931%20–%20facturx%201.0.05%20–%20zugferd%202.1.1%20-%20comfort.scm/html/de/021.htm?https://portal3.gefeg.com/projectdata/invoice/deliverables/installed/publishingproject/zugferd%202.1.1%20-%20facturx%201.0.05/en%2016931%20–%20facturx%201.0.05%20–%20zugferd%202.1.1%20-%20comfort.scm/html/de/0272.htm ).

Your implementation is only processing as what I found is BT-146 ( https://github.com/stephanstapel/ZUGFeRD-csharp/blob/2369f2f81002eb4b115733bf2d3fab5a6b2e2749/ZUGFeRD/InvoiceDescriptor20Reader.cs#L438C1-L453C14 ).

If you need a complete invoice I could mail it to you.

[stephanstapel]

Yes, that is right.

Is this the code you are missing:

ZUGFeRD-csharp/ZUGFeRD/InvoiceDescriptor23CIIReader.cs

Line 545 in 2369f2f

if (tradeLineItem.SelectSingleNode(".//ram:SpecifiedLineTradeSettlement", nsmgr) != null)

[quotschmacher]

Looks good.

[quotschmacher]

you marked this as an enhancement, but i would say it is a bug, as the allowance is missing in the imported representation and tests can not perform correctly.

[stephanstapel]

Restarting after christmas holidays.

@quotschmacher : Could you tell me what is still missing? When I process the example from above, the library reads:

which looks ok. The reason code is missing (to the library), but that should be a different thing.

[tobitege]

For very old ZUGFeRD 2.0 files (before Factur-X), this could be labelled a bug as the implementation for SpecifiedTradeAllowanceCharge is missing for line items in the InvoiceDescriptor20Reader class.
Even though almost 5 years old, I wouldn't be surprised if some vendors' old system would still run on this old spec. 😄

@quotschmacher in your above invoice example, the InvoiceDescriptor23CIIReader would be used as it would have precedence and the raised issue wouldn't occur, as @stephanstapel pointed out.
I'm wondering what kind of tests are you running and with which document contexts?
Maybe you could adapt your tests to prefer the InvoiceDescriptor23CIIReader class?

[tobitege]

@quotschmacher The ReasonCode has been implemented in master now.
Please feel free to close this issue or provided further feedback in case of issues.