lint files by git diff (#149)

* lint files by git diff

* eslint fix

* fix mocha cli error

* update eslint rule keyword-spacing

* fix test case of `git.commit`

* remove bufferstreams

Author: gucong3000

.eslintrc.json

@@ -0,0 +1,92 @@
+{
+  "env": {
+    "node": true
+  },
+  "extends": [
+    "eslint:recommended"
+  ],
+  "root": true,
+  "rules": {
+    "block-scoped-var": "error",
+    "camelcase": "error",
+    "comma-spacing": [
+      "error",
+      {
+        "after": true,
+        "before": false
+      }
+    ],
+    "eqeqeq": [
+      "error",
+      "smart"
+    ],
+    "indent": [
+      "error",
+      2,
+      {
+        "SwitchCase": 1
+      }
+    ],
+    "keyword-spacing": [
+      "error",
+      {
+        "after": true,
+        "before": true
+      }
+    ],
+    "linebreak-style": "error",
+    "max-depth": [
+      "error",
+      5
+    ],
+    "max-statements": [
+      "error",
+      50
+    ],
+    "new-cap": 0,
+    "no-console": [
+      "off",
+      {
+        "allow": [
+          "warn",
+          "error",
+          "info",
+          "dir",
+          "time",
+          "debug"
+        ]
+      }
+    ],
+    "no-extend-native": "error",
+    "no-undef": "error",
+    "no-unused-expressions": "error",
+    "no-unused-vars": "off",
+    "quotes": [
+      "error",
+      "single",
+      {
+        "avoidEscape": true
+      }
+    ],
+    "semi": [
+      "error",
+      "always",
+      {
+        "omitLastInOneLineBlock": false
+      }
+    ],
+    "space-before-blocks": [
+      "error",
+      "always"
+    ],
+    "space-infix-ops": "error",
+    "spaced-comment": [
+      "error",
+      "always"
+    ],
+    "strict": [
+      "error",
+      "safe"
+    ]
+  }
+}

.jshintrc

@@ -1,17 +1,28 @@
-lib-cov
-*.seed
-*.log
 *.csv
 *.dat
+*.gz
+*.log
 *.out
 *.pid
-*.gz
+*.seed
+*.sublime*
 .DS_store
-
-pids
+.editorconfig
+.eslintrc*
+.gitignore
+.grunt
+.lock-wscript
+.node_repl_history
+.stylelintrc*
+.travis.yml
+.vscode
+appveyor.yml
+coverage
+gulpfile.js
+lib-cov
 logs
-results
-
-npm-debug.log
 node_modules
-*.sublime*
+npm-debug.log*
+pids
+results
+test

.npmignore

@@ -1,8 +1,9 @@
 sudo: false
 language: node_js
 node_js:
-  - "4.1.1"
-  - "0.12"
+  - "stable"
+  - "6"
+  - "4"
 before_install:
-  -  git config --global user.email "you@example.com"
-  -  git config --global user.name "Your Name"
+  - git config --global user.email "you@example.com"
+  - git config --global user.name "Your Name"

.travis.yml

@@ -5,34 +5,34 @@ var git = require('../');
 
 // Init a git repo
 
-gulp.task('init', function(){
+gulp.task('init', function() {
   git.init();
 });
 
 
 // Add files
 
-gulp.task('add', function(){
+gulp.task('add', function() {
   gulp.src('./*')
   .pipe(git.add());
 });
 
 
 // Commit files
 
-gulp.task('commit', function(){
+gulp.task('commit', function() {
   gulp.src('./*', {buffer:false})
   .pipe(git.commit('initial commit'));
 });
 
 // Commit files with arguments
-gulp.task('commitopts', function(){
+gulp.task('commitopts', function() {
   gulp.src('./*')
   .pipe(git.commit('initial commit', {args: '-v'}));
 });
 
 // Commit files using raw arguments, without message checking
-gulp.task('commitraw', function(){
+gulp.task('commitraw', function() {
   gulp.src('./*')
   .pipe(git.commit(undefined, {
     args: '-m "initial commit"',
@@ -41,19 +41,19 @@ gulp.task('commitraw', function(){
 });
 
 // Commit files using raw arguments, without message checking
-gulp.task('commitmulti', function(){
+gulp.task('commitmulti', function() {
   gulp.src('./*')
   .pipe(git.commit(['initial commit', 'additional message']));
 });
 
 // Commit files using the multiline option
-gulp.task('commitmultiline', function(){
+gulp.task('commitmultiline', function() {
   gulp.src('./*')
   .pipe(git.commit(['initial commit', 'additional message'], { mutiline: true }));
 });
 
 // Commit files with multiline messages
-gulp.task('commitmultiline', function(){
+gulp.task('commitmultiline', function() {
   gulp.src('./*')
   .pipe(git.commit('initial commit\nadditional message'));
 });
@@ -72,88 +72,105 @@ gulp.task('clonesub', function() {
   });
 });
 
+// Lint js files in index before git commit
+gulp.task('precommit', function() {
+  var eslint = require('gulp-eslint');
+  // get changes between HEAD and index
+  return git.diff('--cached', {
+    args: '-- *.js'
+  })
+    // Read file contents from git index
+    .pipe(git.catFile())
+    // Lint files that different between HEAD and index
+    .pipe(eslint())
+    // Outputs the lint results to the console.
+    .pipe(eslint.format())
+    // To have the process exit with an error code (1) on
+    .pipe(eslint.failAfterError());
+});
+
 // Add remote
 
-gulp.task('remote', function(){
+gulp.task('remote', function() {
   git.addRemote('origin', 'https://github.com/stevelacy/git-test', function (err) {
-    //if (err) ...
+    // if (err) ...
   });
 });
 
 
 // Push to remote repo
 
-gulp.task('push', function(){
+gulp.task('push', function() {
   git.push('origin', 'master', function (err) {
-    //if (err) ...
+    // if (err) ...
   });
 });
 
 
 // Pull from remote repo
 
-gulp.task('pull', function(){
+gulp.task('pull', function() {
   git.pull('origin', 'master', function (err) {
     if (err) console.log(err);
   });
 });
 
 // Pull from remote repo with only origin
 
-gulp.task('pull-origin', function(){
+gulp.task('pull-origin', function() {
   git.pull('origin', function (err) {
     if (err) console.log(err);
   });
 });
 
 // Pull from all remote branches and tags
 
-gulp.task('pull-all', function(){
+gulp.task('pull-all', function() {
   git.pull(function (err) {
     if (err) console.log(err);
   });
 });
 
 // Pull from array of branches
 
-gulp.task('pull-array', function(){
+gulp.task('pull-array', function() {
   git.pull('origin', ['master', 'development'], function (err) {
     if (err) console.log(err);
   });
 });
 
 // Tag the repo
 
-gulp.task('tag', function(){
+gulp.task('tag', function() {
   git.tag('v1.1.1', 'Version message', function (err) {
-    //if (err) ...
+    // if (err) ...
   });
 });
 
 // Tag the repo WITH signed key
-gulp.task('tagsec', function(){
+gulp.task('tagsec', function() {
   git.tag('v1.1.1', 'Version message with signed key', {signed:true}, function (err) {
-    //if (err) ...
+    // if (err) ...
   });
 });
 
-gulp.task('push-tag', function(){
+gulp.task('push-tag', function() {
   git.push('origin', 'v1.1.1', function (err) {
-    //if (err) ...
+    // if (err) ...
   });
 });
 
 
-gulp.task('rm', function(){
+gulp.task('rm', function() {
   gulp.src('./delete')
   .pipe(git.rm({args: '-f'}));
 });
 
-gulp.task('addSubmodule', function(){
+gulp.task('addSubmodule', function() {
   git.addSubmodule('https://github.com/stevelacy/git-test', 'git-test', {args: '-b master'});
 });
 
-gulp.task('updateSubmodules', function(){
+gulp.task('updateSubmodules', function() {
   git.updateSubmodule({args: '--init'});
 });
 

examples/gulpfile.js

@@ -25,9 +25,9 @@ module.exports = function (opt) {
 
     var cmd = 'git add ' + escape(paths) + ' ' + opt.args;
     var that = this;
-    var maxBuffer = opt.maxBuffer || 200*1024;
+    var maxBuffer = opt.maxBuffer || 200 * 1024;
 
-    exec(cmd, {cwd: cwd, maxBuffer: maxBuffer}, function(err, stdout, stderr){
+    exec(cmd, {cwd: cwd, maxBuffer: maxBuffer}, function(err, stdout, stderr) {
       if (err) cb(err);
       if (!opt.quiet) gutil.log(stdout, stderr);
       files.forEach(that.push.bind(that));

lib/add.js

@@ -17,10 +17,10 @@ module.exports = function (remote, url, opt, cb) {
   if (!opt.cwd) opt.cwd = process.cwd();
   if (!opt.args) opt.args = ' ';
 
-  var maxBuffer = opt.maxBuffer || 200*1024;
+  var maxBuffer = opt.maxBuffer || 200 * 1024;
 
   var cmd = 'git remote add ' + opt.args + ' ' + escape([remote, url]);
-  return exec(cmd, {cwd: opt.cwd, maxBuffer: maxBuffer}, function(err, stdout, stderr){
+  return exec(cmd, {cwd: opt.cwd, maxBuffer: maxBuffer}, function(err, stdout, stderr) {
     if (err) cb(err);
     if (!opt.quiet) gutil.log(stdout, stderr);
     cb();