Merge pull request #1203 from larsclausen/cast-to-real

Reject invalid casts to real

Author: larsclausen

elab_expr.cc

@@ -3706,7 +3706,20 @@ NetExpr* PECastType::elaborate_expr(Design*des, NetScope*scope,
 
       NetExpr*tmp = 0;
       if (dynamic_cast<const netreal_t*>(target_type_)) {
-	    return cast_to_real(sub);
+	    switch (sub->expr_type()) {
+		case IVL_VT_REAL:
+		  return sub;
+		case IVL_VT_LOGIC:
+		case IVL_VT_BOOL:
+		  return cast_to_real(sub);
+	        default:
+		  break;
+	    }
+	    cerr << get_fileline() << " error: Expression of type `"
+		 << sub->expr_type() << "` can not be cast to target type `real`."
+		 << endl;
+	    des->errors++;
+	    return nullptr;
       } else if (dynamic_cast<const netstring_t*>(target_type_)) {
 	    if (base_->expr_type() == IVL_VT_STRING)
 		  return sub; // no conversion

ivtest/ivltests/cast_real_invalid1.v

@@ -0,0 +1,12 @@
+// Check that casting a string to real generates an error.
+
+module test;
+
+  real r;
+  string s;
+
+  initial begin
+    r = real'(s); // Error: Cast from string to real not allowed
+  end
+
+endmodule

ivtest/ivltests/cast_real_invalid2.v

@@ -0,0 +1,12 @@
+// Check that casting a array to real generates an error.
+
+module test;
+
+  real r;
+  real a[10];
+
+  initial begin
+    r = real'(a); // Error: Cast from array to real not allowed
+  end
+
+endmodule

ivtest/ivltests/cast_real_invalid3.v

@@ -0,0 +1,12 @@
+// Check that casting a queue to real generates an error.
+
+module test;
+
+  real r;
+  real q[$];
+
+  initial begin
+    r = real'(q); // Error: Cast from queue to real not allowed
+  end
+
+endmodule

ivtest/ivltests/cast_real_invalid4.v

@@ -0,0 +1,12 @@
+// Check that casting a dynamic array to real generates an error.
+
+module test;
+
+  real r;
+  real d[];
+
+  initial begin
+    r = real'(d); // Error: Cast from dynamic array to real not allowed
+  end
+
+endmodule

ivtest/regress-vvp.list

@@ -72,6 +72,10 @@ case3				vvp_tests/case3.json
 casex_synth			vvp_tests/casex_synth.json
 cast_int_ams			vvp_tests/cast_int_ams.json
 cast_int_ams-vlog95		vvp_tests/cast_int_ams-vlog95.json
+cast_real_invalid1		vvp_tests/cast_real_invalid1.json
+cast_real_invalid2		vvp_tests/cast_real_invalid2.json
+cast_real_invalid3		vvp_tests/cast_real_invalid3.json
+cast_real_invalid4		vvp_tests/cast_real_invalid4.json
 comment1			vvp_tests/comment1.json
 constfunc4_ams			vvp_tests/constfunc4_ams.json
 constfunc4_ams-vlog95		vvp_tests/constfunc4_ams-vlog95.json

ivtest/vvp_tests/cast_real_invalid1.json

@@ -0,0 +1,5 @@
+{
+    "type"          : "CE",
+    "source"        : "cast_real_invalid1.v",
+    "iverilog-args" : [ "-g2005-sv" ]
+}

ivtest/vvp_tests/cast_real_invalid2.json

@@ -0,0 +1,5 @@
+{
+    "type"          : "CE",
+    "source"        : "cast_real_invalid2.v",
+    "iverilog-args" : [ "-g2005-sv" ]
+}

ivtest/vvp_tests/cast_real_invalid3.json

@@ -0,0 +1,5 @@
+{
+    "type"          : "CE",
+    "source"        : "cast_real_invalid3.v",
+    "iverilog-args" : [ "-g2005-sv" ]
+}

ivtest/vvp_tests/cast_real_invalid4.json

@@ -0,0 +1,5 @@
+{
+    "type"          : "CE",
+    "source"        : "cast_real_invalid4.v",
+    "iverilog-args" : [ "-g2005-sv" ]
+}