-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Remove "streamdal" action #375
Comments
Hi @dselans I'm very interested in contributing to Plumber and this issue caught my eye! I have experience with Go and Protobuf and I'd love to give this a shot for Hacktoberfest, which starts tomorrow. Would it be alright if I take a closer look and reach out with any initial questions I have before diving into the implementation? |
Yeah absolutely, go for it! |
Hi @dselans, I've created a draft PR. Could you please review it to ensure it fully addresses the requirement to remove Streamdal? I'm also having trouble testing it. I've tried copying the newly generated plumber-schemas to the |
plumber
contains astreamdal
action that allows you tologin
,logout
,search
etc. on the old Streamdal (event-driven) SaaS platform.Since
streamdal
moved into the open source data quality space, theplumber streamdal ...
action no longer makes sense.To remove this, you will need to update the protobuf definitions available here: batchcorp/schemas
^ This is because the
plumber
CLI is defined as protobuf (because the CLI options are highly coupled with the actions and params for the actions that plumber takes likeplumber read rabbitmq ...
).This task is:
protobuf
but not in GoThe text was updated successfully, but these errors were encountered: