Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Turn rating feature into something presentable #41

Open
2 of 9 tasks
Simon-Laux opened this issue Oct 4, 2020 · 1 comment
Open
2 of 9 tasks

Turn rating feature into something presentable #41

Simon-Laux opened this issue Oct 4, 2020 · 1 comment

Comments

@Simon-Laux
Copy link
Collaborator

Simon-Laux commented Oct 4, 2020

TODO / Problems:

  • XSS vulnerability (see the osm app entry in the store app to know what I mean)
  • you can go into the rating screen, even when you already rated the app
  • you can not use arrow up in the description field
  • no username where ratings are
  • comment is mandatory (not optional) to discourage spam (you need a comment with atleast 3 chars: 2 emojis or a simple word like Awesome, good or whatever)
  • no possibility to set the username nor migrate the account

Optional ideas:

  • Code cleanup
    • move functions inside of an Rating namespace/object like we done it for the download counter
    • move network request functions to backend-api file, so later when implementing proxies we can do it all at one place (like it's done for the download counter)
@strukturart
Copy link
Owner

strukturart commented Oct 5, 2020

you can not use arrow up in the description field

but you can use left and right, up and down is to switch between star raiting and comment field

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants