Decide on if the service wrapper should return a shared instance or new instances

[swichers]

Given:

$container->setParameter('acsf.client.connection', ['environment' => 'live'] +
  $base_config);
$live_client = $container->get('acsf.client');

$container->setParameter('acsf.client.connection', ['environment' => 'uat'] +
  $base_config);
$uat_client = $container->get('acsf.client');
print_r($uat_client->getConfig());

$uat_client will still contain the original configuration. This is because services are shared by default with Symfony: https://symfony.com/doc/current/service_container/shared.html

It's easy enough to change configuration after the client has been requested:

$container->setParameter('acsf.client.connection', ['environment' => 'live'] +
  $base_config);
$client = $container->get('acsf.client');
$client->setConfig(['environment' => 'uat'] + $client->getConfig());

This makes difficult to work with two separate clients at once. It also may pose problems in the future if something changes around the config system.

It can be mitigated by manually creating the Client object without using the service. It would be helpful to have a client factory service that could spin of instances per environment.