Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework dependencies on Ledger common types #6834

Open
stringhandler opened this issue Mar 3, 2025 · 0 comments
Open

Rework dependencies on Ledger common types #6834

stringhandler opened this issue Mar 3, 2025 · 0 comments

Comments

@stringhandler
Copy link
Collaborator

There are two places where common crates reference crates in the applications/ledger folder.

  1. common_types references minotari_ledger_wallet_common
  2. core references minotari_ledger_wallet_comms

This is wrong because a general purpose library (e.g. core) references a specific purpose library (e.g. ledger_comms).

A possible solution is to move the types from the very specific crate to the more general crate, or perhaps to rename the crates better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stringhandler