Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some strings are missing for translation #71

Open
ArionWT opened this issue Feb 8, 2019 · 7 comments
Open

Some strings are missing for translation #71

ArionWT opened this issue Feb 8, 2019 · 7 comments

Comments

@ArionWT
Copy link

ArionWT commented Feb 8, 2019

Hello,
There aren't some strings for translation on Transifex:

Server
body
marking
decoration
hands
feet
eyes

(screenshots on Imgur)

If you add them to the .json file manually, translated strings works in the game (at least in version 0.7.2). Maybe this is some kind of bug in some convert script for loading on Transifex?

@Dune-jr
Copy link
Member

Dune-jr commented Feb 8, 2019

Forwarded to teeworlds/teeworlds#2027 since this is a code issue

@Dune-jr
Copy link
Member

Dune-jr commented Feb 9, 2019

Fixed by teeworlds/teeworlds#2029, updated Transifex

@ArionWT
Copy link
Author

ArionWT commented Feb 9, 2019

Seems other two strings don't work in the new menu:
All in src\game\client\components\menus.cpp:2532
Favorites in src\game\client\components\menus.cpp:2530
They are in .json file, but not applied ingame.
_2019-02-10_00-06-49

@Dune-jr
Copy link
Member

Dune-jr commented Feb 9, 2019

Those are filters defined in ui_settings.json. Since filters can be customized by the user (but not really those), it would be difficult to localize them.

@oy should we change that somehow and localize the default filter names, or leave it as is?

@oy
Copy link
Member

oy commented Feb 10, 2019

@Dune-jr yeah, we could localize them.

@ArionWT
Copy link
Author

ArionWT commented Mar 29, 2019

Hello,
Missed one string on Transifex:
Menu background transparency

And string №336 You have to wait %1.f seconds to change identity. on Transifex may be You have to wait %1.0f seconds to change identity. due this commit.

@Dune-jr
Copy link
Member

Dune-jr commented Mar 29, 2019

Yeah, need to update Transifex for the menu background transparency. The second thing isn't a big deal, I can automate a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants