Skip to content

Commit ffaff61

Browse files
committed
Address PR comments
1 parent 5607228 commit ffaff61

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

examples/fabric-admin/rpc/RpcServer.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ class FabricAdmin final : public rpc::FabricAdmin, public IcdManager::Delegate
9898
chip_rpc_OperationStatus & response) override
9999
{
100100
VerifyOrReturnValue(request.has_id, pw::Status::InvalidArgument());
101-
// TODO: OpenDeviceCommissioningWindow uses the same controller every time and doesn't currently accept FabricIndex. For now
102-
// we are dropping fabric index from the scoped node id.
101+
// TODO(#35875): OpenDeviceCommissioningWindow uses the same controller every time and doesn't currently accept
102+
// FabricIndex. For now we are dropping fabric index from the scoped node id.
103103
NodeId nodeId = request.id.node_id;
104104
uint32_t commissioningTimeoutSec = request.commissioning_timeout;
105105
uint32_t iterations = request.iterations;

examples/fabric-bridge-app/fabric-bridge-common/include/BridgedDeviceManager.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class BridgedDeviceManager
9797
*
9898
* This function attempts to remove a device and the associated dynamic endpoint by iterating through
9999
* the available device and checking if the device matches the specified ScopedNodeId. If the device is
100-
* found, it clears the dynamic endpoint.
100+
* found, it removes the dynamic endpoint.
101101
*
102102
* @param scopedNodeId The ScopedNodeId of the device to be removed.
103103
* @return unsigned of the index of the removed dynamic endpoint if successful, nullopt otherwise.

0 commit comments

Comments
 (0)