Skip to content

chore: fix regex validation to enforce exact match (public or private) #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 8, 2025
Merged

chore: fix regex validation to enforce exact match (public or private) #710

merged 5 commits into from
Sep 8, 2025

Conversation

piyush117
Copy link
Contributor

@piyush117 piyush117 commented Sep 3, 2025 •
edited
Loading

https://github.ibm.com/GoldenEye/issues/issues/15651
Fix regex validation to enforce exact match (public or private)

@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117 piyush117 changed the title chore: Fix regex validation to enforce exact match (public or private) chore: fix regex validation to enforce exact match (public or private) Sep 3, 2025
shemau
shemau previously requested changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There other places where this logic would be required:

    condition     = can(regex("public|public-and-private|private", var.service_endpoints))

@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117 piyush117 requested a review from shemau September 4, 2025 06:27
@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 3e54543 into main Sep 8, 2025
2 checks passed
@ocofaigh ocofaigh deleted the update_regex branch September 8, 2025 07:55
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 4.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imprateeksh imprateeksh imprateeksh approved these changes

@rajatagarwal-ibm rajatagarwal-ibm Awaiting requested review from rajatagarwal-ibm rajatagarwal-ibm is a code owner

@Ak-sky Ak-sky Awaiting requested review from Ak-sky Ak-sky is a code owner

@shemau shemau Awaiting requested review from shemau

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@piyush117 @terraform-ibm-modules-ops @shemau @imprateeksh @ocofaigh