Merge pull request #2 from timogoebel/superfluous_raise

remove superfluous exception handling

Author: martencassel

lib/smart_proxy_realm_ad/provider.rb

@@ -33,15 +33,11 @@ def create realm, hostfqdn, params
             password = generate_password
             result = { :randompassword => password }
 
-            begin
-                if params[:rebuild] == "true"
-                    do_host_rebuild hostfqdn, password
-                else
-                    do_host_create hostfqdn, password
-                end
-            rescue 
-                raise
-            end 
+            if params[:rebuild] == "true"
+              do_host_rebuild hostfqdn, password
+            else
+              do_host_create hostfqdn, password
+            end
 
             JSON.pretty_generate(result)
         end
@@ -50,11 +46,7 @@ def delete realm, hostfqdn
             logger.info "Proxy::AdRealm: delete... #{realm}, #{hostfqdn}"
             kinit_radcli_connect
             check_realm realm
-            begin
-                radcli_delete hostfqdn
-                rescue Adcli::AdEnroll::Exception =>
-                raise
-            end
+            radcli_delete hostfqdn
         end
 
         private
@@ -63,10 +55,10 @@ def hostfqdn_to_hostname host_fqdn
             begin
               host_fqdn_split = host_fqdn.split('.')
               host_fqdn_split[0]
-            rescue  
-              logger.debug "hostfqdn_to_hostname error"
-              raise
-            end        
+            rescue => e
+              logger.debug "hostfqdn_to_hostname error: #{e}"
+              raise e
+            end
         end
 
         def do_host_create hostfqdn, password