Use reusable action to do Smart Proxy testing

- Make use of the reusable smart_proxy_plugin action in the github ci workflow
- Respect SMART_PROXY_BRANCH in Gemfile
- Make sure action detects ruby version from the gemspec

Author: martencassel

.github/workflows/ci.yml

@@ -4,27 +4,13 @@ on:
   - pull_request
   - push
 
+concurrency:
+  group: ${{ github.ref_name }}-${{ github.workflow }}
+  cancel-in-progress: true
+
 jobs:
   test:
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        ruby:
-          - "2.5"
-          - "2.6"
-          - "2.7"
-    name: Ruby ${{ matrix.ruby }}
-    steps:
-      - uses: actions/checkout@v3
-      - name: Install development headers
-        run: sudo apt install libkrb5-dev libldap-dev libsasl2-dev -y
-      - name: Install Ruby ${{ matrix.ruby }}
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby }}
-          bundler-cache: true
-      - name: Run tests
-        run: bundle exec rake test
-      - name: Verify gem builds
-        run: gem build *.gemspec
+    name: Tests
+    uses: theforeman/actions/.github/workflows/smart_proxy_plugin.yml@v0
+    with:
+      extra_packages: "libkrb5-dev libldap-dev libsasl2-dev"

Gemfile

@@ -5,5 +5,5 @@ gemspec
 
 group :development do
   gem 'rack-test'
-  gem 'smart_proxy', :git => 'https://github.com/theforeman/smart-proxy.git', :branch => 'develop'
+  gem 'smart_proxy', github: 'theforeman/smart-proxy', branch: ENV.fetch('SMART_PROXY_BRANCH', 'develop')
 end

smart_proxy_realm_ad_plugin.gemspec

@@ -7,20 +7,21 @@ Gem::Specification.new do |s|
   s.name        = 'smart_proxy_realm_ad_plugin'
   s.version     = Proxy::AdRealm::VERSION
   s.date        = Date.today.to_s
-  s.license     = 'GPL-3.0'
+  s.license     = 'GPL-3.0-only'
   s.authors     = ['Mårten Cassel']
   s.email       = ['marten.cassel@gmail.com']
   s.homepage    = 'https://github.com/theforeman/smart_proxy_realm_ad_plugin'
 
   s.summary     = "A realm ad provider plugin for Foreman's smart proxy"
-  s.description = "A realm ad provider plugin for Foreman's smart proxy"
+  s.description = "This plugin provides Active Directory realm support for Foreman's smart proxy, allowing seamless integration and management of AD realms."
 
   s.files       = Dir['{config,lib,bundler.d}/**/*'] + ['README.md', 'LICENSE']
   s.test_files  = Dir['test/**/*']
 
-  s.add_development_dependency('rake')
-  s.add_development_dependency('mocha')
-  s.add_development_dependency('test-unit')
-  s.add_dependency('rkerberos')
-  s.add_dependency('radcli')
+  s.add_development_dependency('rake', '~> 13.0')
+  s.add_development_dependency('mocha', '~> 2.6')
+  s.add_development_dependency('test-unit', '~> 3.6')
+  s.add_dependency('rkerberos', '~> 0.1')
+  s.add_dependency('radcli', '~> 1.1')
+  s.required_ruby_version = '>= 2.7', '< 4'
 end