Skip to content

Commit 74c3e81

Browse files
committed
Update gemspec to address gemspec validation errors
- Use bounded requirements for dependencies: - Set required Ruby version to '>= 2.7'
1 parent e07d7f2 commit 74c3e81

File tree

3 files changed

+17
-30
lines changed

3 files changed

+17
-30
lines changed

.github/workflows/ci.yml

+8-22
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,13 @@ on:
44
- pull_request
55
- push
66

7+
concurrency:
8+
group: ${{ github.ref_name }}-${{ github.workflow }}
9+
cancel-in-progress: true
10+
711
jobs:
812
test:
9-
runs-on: ubuntu-latest
10-
strategy:
11-
fail-fast: false
12-
matrix:
13-
ruby:
14-
- "2.5"
15-
- "2.6"
16-
- "2.7"
17-
name: Ruby ${{ matrix.ruby }}
18-
steps:
19-
- uses: actions/checkout@v3
20-
- name: Install development headers
21-
run: sudo apt install libkrb5-dev libldap-dev libsasl2-dev -y
22-
- name: Install Ruby ${{ matrix.ruby }}
23-
uses: ruby/setup-ruby@v1
24-
with:
25-
ruby-version: ${{ matrix.ruby }}
26-
bundler-cache: true
27-
- name: Run tests
28-
run: bundle exec rake test
29-
- name: Verify gem builds
30-
run: gem build *.gemspec
13+
name: Tests
14+
uses: theforeman/actions/.github/workflows/smart_proxy_plugin.yml@v0
15+
with:
16+
extra_packages: "libkrb5-dev libldap-dev libsasl2-dev"

Gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ gemspec
55

66
group :development do
77
gem 'rack-test'
8-
gem 'smart_proxy', :git => 'https://github.com/theforeman/smart-proxy.git', :branch => 'develop'
8+
gem 'smart_proxy', github: 'theforeman/smart-proxy', branch: ENV.fetch('SMART_PROXY_BRANCH', 'develop')
99
end

smart_proxy_realm_ad_plugin.gemspec

+8-7
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,21 @@ Gem::Specification.new do |s|
77
s.name = 'smart_proxy_realm_ad_plugin'
88
s.version = Proxy::AdRealm::VERSION
99
s.date = Date.today.to_s
10-
s.license = 'GPL-3.0'
10+
s.license = 'GPL-3.0-only'
1111
s.authors = ['Mårten Cassel']
1212
s.email = ['marten.cassel@gmail.com']
1313
s.homepage = 'https://github.com/theforeman/smart_proxy_realm_ad_plugin'
1414

1515
s.summary = "A realm ad provider plugin for Foreman's smart proxy"
16-
s.description = "A realm ad provider plugin for Foreman's smart proxy"
16+
s.description = "This plugin provides direct Active Directory realm support for Foreman's smart proxy."
1717

1818
s.files = Dir['{config,lib,bundler.d}/**/*'] + ['README.md', 'LICENSE']
1919
s.test_files = Dir['test/**/*']
2020

21-
s.add_development_dependency('rake')
22-
s.add_development_dependency('mocha')
23-
s.add_development_dependency('test-unit')
24-
s.add_dependency('rkerberos')
25-
s.add_dependency('radcli')
21+
s.add_development_dependency('rake', '~> 13.0')
22+
s.add_development_dependency('mocha', '~> 2.6')
23+
s.add_development_dependency('test-unit', '~> 3.6')
24+
s.add_dependency('rkerberos', '~> 0.1')
25+
s.add_dependency('radcli', '~> 1.1')
26+
s.required_ruby_version = '>= 2.7', '< 4'
2627
end

0 commit comments

Comments
 (0)