remove passgen dependency

Author: timogoebel

Gemfile

@@ -2,5 +2,5 @@ source 'https://rubygems.org'
 gemspec
 
 group :development do
-  gem 'smart_proxy', :github => 'theforeman/smart-proxy', :branch => 'develop'
-end
+  gem 'smart_proxy', :git => 'https://github.com/theforeman/smart-proxy.git', :branch => 'develop'
+end

extra/redhat/rubygem-passgen-1.0.2.spec

@@ -17,7 +17,6 @@ Requires: foreman-proxy >= 1.15
 Requires: ruby(release)
 Requires: ruby
 Requires: ruby(rubygems)
-Requires: rubygem(passgen)
 Requires: rubygem(rkerberos)
 Requires: rubygem(radcli)
 BuildRequires: ruby(release)

extra/redhat/rubygem-smart_proxy_realm_ad_plugin-0.1.spec

@@ -1,6 +1,5 @@
 require 'proxy/kerberos'
 require 'radcli'
-require 'passgen'
 
 module Proxy::AdRealm
   class Provider
@@ -93,7 +92,8 @@ def radcli_join(hostfqdn, hostname, password)
     end
 
     def generate_password
-      Passgen.generate(:length => 20)
+      characters = ('A'..'Z').to_a + ('a'..'z').to_a + (0..9).to_a
+      Array.new(20) { characters.sample }.join
     end
 
     def radcli_password(hostname, password)

lib/smart_proxy_realm_ad/provider.rb

@@ -20,6 +20,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency('mocha')
   s.add_development_dependency('test-unit')
   s.add_dependency('rkerberos')
-  s.add_dependency('passgen')
   s.add_dependency('radcli')
 end

smart_proxy_realm_ad_plugin.gemspec

@@ -6,56 +6,56 @@
 class RealmAdTest < Test::Unit::TestCase
   def setup
     @realm = 'test_realm'
-    @provider = Proxy::AdRealm::Provider.new('example.com', 'keytab_path', 'principal', 'domain-controller')
+    @provider = Proxy::AdRealm::Provider.new('example.com', 'keytab_path', 'principal', 'domain-controller', nil)
   end
 
   def test_create_host
     hostname = 'host.example.com'
-    password = 'a_password'
     params = {}
-    params[:rebuild] = "false"
+    params[:rebuild] = 'false'
     @provider.expects(:check_realm).with(@realm)
     @provider.expects(:kinit_radcli_connect)
-    @provider.expects(:generate_password).returns(password)
     @provider.expects(:radcli_join)
-    @provider.create(@realm, hostname, params)
+    response = JSON.parse(@provider.create(@realm, hostname, params))
+    assert_kind_of String, response['randompassword']
+    assert_equal 20, response['randompassword'].size
   end
 
   def test_create_with_unrecognized_realm_raises_exception
-    assert_raises(Exception) { @provider.create('unknown_realm', 'a_host', {})}
+    assert_raises(Exception) { @provider.create('unknown_realm', 'a_host', {}) }
   end
 
   def test_create_rebuild
     hostname = 'host.example.com'
-    password = 'a_password'
     params = {}
-    params[:rebuild] = "true"
+    params[:rebuild] = 'true'
     @provider.expects(:check_realm).with(@realm)
     @provider.expects(:kinit_radcli_connect)
-    @provider.expects(:generate_password).returns(password)
     @provider.expects(:radcli_password)
-    @provider.create(@realm, hostname, params)
+    response = JSON.parse(@provider.create(@realm, hostname, params))
+    assert_kind_of String, response['randompassword']
+    assert_equal 20, response['randompassword'].size
   end
 
   def test_rebuild_with_unrecognized_realm_raises_exception
     params = {}
-    params[:rebuild] = "true"
+    params[:rebuild] = 'true'
     assert_raises(Exception) { @provider.create('unknown_realm', 'a_host', params) }
   end
 
   def test_find
     assert_true @provider.find('a_host_fqdn')
   end
 
-  def test_delete 
+  def test_delete
     @provider.expects(:check_realm).with(@realm)
     @provider.expects(:kinit_radcli_connect)
     @provider.expects(:radcli_delete)
     @provider.delete(@realm, 'a_host')
   end
- 
+
   def test_delete_unrecognized_realm_raises_exception
     @provider.expects(:kinit_radcli_connect)
     assert_raises(Exception) { @provider.delete('unkown_realm', 'a_host') }
   end
-end
+end