Skip to content

Commit 0d78b5f

Browse files
Fix attribute-table logs to not log strings as %p. (project-chip#35941)
Fixes project-chip#35928
1 parent 9ccc52e commit 0d78b5f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/app/util/attribute-table.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -342,8 +342,8 @@ Status emAfWriteAttribute(const ConcreteAttributePath & path, const EmberAfWrite
342342
// if we dont support that attribute
343343
if (metadata == nullptr)
344344
{
345-
ChipLogProgress(Zcl, "%p ep %x clus " ChipLogFormatMEI " attr " ChipLogFormatMEI " not supported",
346-
"WRITE ERR: ", path.mEndpointId, ChipLogValueMEI(path.mClusterId), ChipLogValueMEI(path.mAttributeId));
345+
ChipLogProgress(Zcl, "WRITE ERR: ep %x clus " ChipLogFormatMEI " attr " ChipLogFormatMEI " not supported", path.mEndpointId,
346+
ChipLogValueMEI(path.mClusterId), ChipLogValueMEI(path.mAttributeId));
347347
return status;
348348
}
349349

@@ -352,13 +352,13 @@ Status emAfWriteAttribute(const ConcreteAttributePath & path, const EmberAfWrite
352352
{
353353
if (input.dataType != metadata->attributeType)
354354
{
355-
ChipLogProgress(Zcl, "%p invalid data type", "WRITE ERR: ");
355+
ChipLogProgress(Zcl, "WRITE ERR: invalid data type");
356356
return Status::InvalidDataType;
357357
}
358358

359359
if (metadata->IsReadOnly())
360360
{
361-
ChipLogProgress(Zcl, "%p attr not writable", "WRITE ERR: ");
361+
ChipLogProgress(Zcl, "WRITE ERR: attr not writable");
362362
return Status::UnsupportedWrite;
363363
}
364364
}

0 commit comments

Comments
 (0)