fix memory leak

Author: tianfeng-yang

src/controller/python/chip/clusters/attribute.cpp

@@ -225,27 +225,25 @@ class ReadClientCallback : public ReadClient::Callback
 
     void OnReportEnd() override { gOnReportEndCallback(mAppContext); }
 
-    void OnDone(ReadClient *) override
+    void OnDone(ReadClient * apReadClient) override
     {
         gOnReadDoneCallback(mAppContext);
 
         // SubscriptionType will delete with pychip_ReadClient_Abort
-        if (mReadClient->IsReadType())
+        if (apReadClient->IsReadType())
         {
+            delete apReadClient;
             delete this;
         }
     };
 
-    void AdoptReadClient(std::unique_ptr<ReadClient> apReadClient) { mReadClient = std::move(apReadClient); }
-
     void SetAutoResubscribe(bool autoResubscribe) { mAutoResubscribe = autoResubscribe; }
 
 private:
     BufferedReadCallback mBufferedReadCallback;
 
     PyObject * mAppContext;
 
-    std::unique_ptr<ReadClient> mReadClient;
     bool mAutoResubscribe = true;
 };
 
@@ -459,6 +457,7 @@ void pychip_ReadClient_Abort(ReadClient * apReadClient, ReadClientCallback * apC
     VerifyOrDie(apReadClient != nullptr);
     VerifyOrDie(apCallback != nullptr);
 
+    delete apReadClient;
     delete apCallback;
 }
 
@@ -609,10 +608,6 @@ PyChipError pychip_ReadClient_Read(void * appContext, ReadClient ** pReadClient,
     *pReadClient = readClient.get();
     *pCallback   = callback.get();
 
-    callback->AdoptReadClient(std::move(readClient));
-
-    callback.release();
-
 exit:
     return ToPyChipError(err);
 }