memory does not need to be moved

Author: tianfeng-yang

src/controller/python/chip/clusters/attribute.cpp

@@ -225,23 +225,21 @@ class ReadClientCallback : public ReadClient::Callback
 
     void OnReportEnd() override { gOnReportEndCallback(mAppContext); }
 
-    void OnDone(ReadClient *) override
+    void OnDone(ReadClient * apReadClient) override
     {
         gOnReadDoneCallback(mAppContext);
 
+        delete apReadClient;
         delete this;
     };
 
-    void AdoptReadClient(std::unique_ptr<ReadClient> apReadClient) { mReadClient = std::move(apReadClient); }
-
     void SetAutoResubscribe(bool autoResubscribe) { mAutoResubscribe = autoResubscribe; }
 
 private:
     BufferedReadCallback mBufferedReadCallback;
 
     PyObject * mAppContext;
 
-    std::unique_ptr<ReadClient> mReadClient;
     bool mAutoResubscribe = true;
 };
 
@@ -455,6 +453,7 @@ void pychip_ReadClient_Abort(ReadClient * apReadClient, ReadClientCallback * apC
     VerifyOrDie(apReadClient != nullptr);
     VerifyOrDie(apCallback != nullptr);
 
+    delete apReadClient;
     delete apCallback;
 }
 
@@ -602,12 +601,8 @@ PyChipError pychip_ReadClient_Read(void * appContext, ReadClient ** pReadClient,
         }
     }
 
-    *pReadClient = readClient.get();
-    *pCallback   = callback.get();
-
-    callback->AdoptReadClient(std::move(readClient));
-
-    callback.release();
+    *pReadClient = readClient.release();
+    *pCallback   = callback.release();
 
 exit:
     return ToPyChipError(err);