Skip to content

Commit 5355937

Browse files
thomasp85thomasp85
committed
Prepare for release and fix issues
1 parent d6d0523 commit 5355937

10 files changed

+1367
-1798
lines changed

‎DESCRIPTION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Package: ggplot2
2-
Version: 3.4.1.9000
2+
Version: 3.4.2
33
Title: Create Elegant Data Visualisations Using the Grammar of Graphics
44
Authors@R: c(
55
person("Hadley", "Wickham", , "hadley@posit.co", role = "aut",

‎NEWS.md

+30-14
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,44 @@
1-
# ggplot2 (development version)
1+
# ggplot2 3.4.2
2+
This is a hotfix release anticipating changes in r-devel, but folds in upkeep
3+
changes and a few bug fixes as well.
4+
5+
## Minor improvements
6+
7+
* Various type checks and their messages have been standardised
8+
(@teunbrand, #4834).
9+
10+
* ggplot2 now uses `scales::DiscreteRange` and `scales::ContinuousRange`, which
11+
are available to write scale extensions from scratch (@teunbrand, #2710).
12+
13+
* The `layer_data()`, `layer_scales()` and `layer_grob()` now have the default
14+
`plot = last_plot()` (@teunbrand, #5166).
15+
16+
* The `datetime_scale()` scale constructor is now exported for use in extension
17+
packages (@teunbrand, #4701).
18+
19+
## Bug fixes
20+
21+
* `update_geom_defaults()` and `update_stat_defaults()` now return properly
22+
classed objects and have updated docs (@dkahle, #5146).
23+
24+
* For the purposes of checking required or non-missing aesthetics, character
25+
vectors are no longer considered non-finite (@teunbrand, @4284).
226

327
* `annotation_logticks()` skips drawing ticks when the scale range is non-finite
428
instead of throwing an error (@teunbrand, #5229).
29+
530
* Fixed spurious warnings when the `weight` was used in `stat_bin_2d()`,
631
`stat_boxplot()`, `stat_contour()`, `stat_bin_hex()` and `stat_quantile()`
732
(@teunbrand, #5216).
8-
* Various type checks and their messages have been standardised
9-
(@teunbrand, #4834).
10-
* The `layer_data()`, `layer_scales()` and `layer_grob()` now have the default
11-
`plot = last_plot()` (@teunbrand, #5166).
33+
1234
* To prevent changing the plotting order, `stat_sf()` is now computed per panel
1335
instead of per group (@teunbrand, #4340).
14-
* ggplot2 now uses `scales::DiscreteRange` and `scales::ContinuousRange`, which
15-
are available to write scale extensions from scratch (@teunbrand, #2710).
16-
* For the purposes of checking required or non-missing aesthetics, character
17-
vectors are no longer considered non-finite (@teunbrand, @4284).
36+
1837
* Fixed bug in `coord_sf()` where graticule lines didn't obey
19-
`panel.grid.major`'s linewidth setting (@teunbrand, #5179)
20-
* The `datetime_scale()` scale constructor is now exported for use in extension
21-
packages (@teunbrand, #4701).
38+
`panel.grid.major`'s linewidth setting (@teunbrand, #5179).
39+
2240
* `geom_text()` drops observations where `angle = NA` instead of throwing an
2341
error (@teunbrand, #2757).
24-
* `update_geom_defaults()` and `update_stat_defaults()` now return properly
25-
classed objects and have updated docs (@dkahle, #5146)
2642

2743
# ggplot2 3.4.1
2844
This is a small release focusing on fixing regressions in the 3.4.0 release

‎R/facet-grid-.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ facet_grid <- function(rows = NULL, cols = NULL, scales = "fixed",
116116
# `facets` is deprecated and renamed to `rows`
117117
if (lifecycle::is_present(facets)) {
118118
deprecate_warn0("2.2.0", "facet_grid(facets)", "facet_grid(rows)")
119-
row <- facets
119+
rows <- facets
120120
}
121121

122122
# Should become a warning in a future release

‎R/quick-plot.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ qplot <- function(x, y, ..., data, facets = NULL, margins = FALSE,
142142
} else if (is.formula(facets) && length(facets) == 2) {
143143
p <- p + facet_wrap(facets)
144144
} else {
145-
p <- p + facet_grid(facets = deparse(facets), margins = margins)
145+
p <- p + facet_grid(rows = deparse(facets), margins = margins)
146146
}
147147

148148
if (!is.null(main)) p <- p + ggtitle(main)

‎R/stat-smooth.R

+6-3
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ StatSmooth <- ggproto("StatSmooth", Stat,
113113
msg <- c(msg, paste0("formula = '", deparse(params$formula), "'"))
114114
}
115115
if (identical(params$method, "gam")) {
116-
params$method <- mgcv::gam
116+
params$method <- gam_method()
117117
}
118118

119119
if (length(msg) > 0) {
@@ -161,13 +161,13 @@ StatSmooth <- ggproto("StatSmooth", Stat,
161161

162162
if (is.character(method)) {
163163
if (identical(method, "gam")) {
164-
method <- mgcv::gam
164+
method <- gam_method()
165165
} else {
166166
method <- match.fun(method)
167167
}
168168
}
169169
# If gam and gam's method is not specified by the user then use REML
170-
if (identical(method, mgcv::gam) && is.null(method.args$method)) {
170+
if (identical(method, gam_method()) && is.null(method.args$method)) {
171171
method.args$method <- "REML"
172172
}
173173

@@ -187,3 +187,6 @@ StatSmooth <- ggproto("StatSmooth", Stat,
187187

188188
required_aes = c("x", "y")
189189
)
190+
191+
# This function exists to silence an undeclared import warning
192+
gam_method <- function() mgcv::gam

‎cran-comments.md

+57-54
Original file line numberDiff line numberDiff line change
@@ -1,70 +1,73 @@
1-
This is a patch release fixing a couple of regressions in the last release. We
2-
see two failing revdeps at the time of submission. Both have been notified 16
3-
days ago.
1+
This is a patch release responding to a request from CRAN about new warnings in
2+
R-devel. It also includes a small batch of of bug fixes since last release.
3+
There are no user facing changes.
4+
5+
All breaking reverse dependencies have been notified.
46

57
## revdepcheck results
68

7-
We checked 4375 reverse dependencies (4350 from CRAN + 25 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
9+
We checked 4503 reverse dependencies (4468 from CRAN + 35 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
810

9-
* We saw 2 new problems
10-
* We failed to check 46 packages
11+
* We saw 8 new problems
12+
* We failed to check 29 packages
1113

1214
Issues with CRAN packages are summarised below.
1315

1416
### New problems
1517
(This reports the first line of each new failure)
1618

17-
* listdown
18-
checking tests ... ERROR
19+
* afex
20+
checking re-building of vignette outputs ... WARNING
21+
22+
* dalmatian
23+
checking re-building of vignette outputs ... WARNING
24+
25+
* DriveML
26+
checking re-building of vignette outputs ... WARNING
27+
28+
* EcoEnsemble
29+
checking re-building of vignette outputs ... WARNING
30+
31+
* ggtern
32+
checking Rd files ... WARNING
33+
34+
* siland
35+
checking re-building of vignette outputs ... WARNING
36+
37+
* TCIU
38+
checking re-building of vignette outputs ... WARNING
1939

2040
* xpose
2141
checking tests ... ERROR
2242

2343
### Failed to check
2444

25-
* AFM (NA)
26-
* AssetCorr (NA)
27-
* bayesnec (NA)
28-
* bayesrules (NA)
29-
* cinaR (NA)
30-
* eefAnalytics (NA)
31-
* escalation (NA)
32-
* ESTER (NA)
33-
* genekitr (NA)
34-
* ggPMX (NA)
35-
* grandR (NA)
36-
* hmmTMB (NA)
37-
* immcp (NA)
38-
* INSPECTumours (NA)
39-
* IRexamples (NA)
40-
* loon.ggplot (NA)
41-
* MarketMatching (NA)
42-
* MARVEL (NA)
43-
* multilevelcoda (NA)
44-
* nestedcv (NA)
45-
* nlmixr2 (NA)
46-
* nlmixr2extra (NA)
47-
* nlmixr2plot (NA)
48-
* nlmixr2rpt (NA)
49-
* numbat (NA)
50-
* OlinkAnalyze (NA)
51-
* OpenMx (NA)
52-
* ordbetareg (NA)
53-
* PFIM (NA)
54-
* PlasmaMutationDetector2 (NA)
55-
* Platypus (NA)
56-
* RcppCensSpatial (NA)
57-
* rdddr (NA)
58-
* rdss (NA)
59-
* rstan (NA)
60-
* RVA (NA)
61-
* SCpubr (NA)
62-
* tidyposterior (NA)
63-
* tidySEM (NA)
64-
* tinyarray (NA)
65-
* TVMM (NA)
66-
* valse (NA)
67-
* vivid (NA)
68-
* wearables (NA)
69-
* webSDM (NA)
70-
* xpose.nlmixr2 (NA)
45+
* beadplexr (NA)
46+
* CausalImpact (NA)
47+
* CensMFM (NA)
48+
* cinaR (NA)
49+
* ctsem (NA)
50+
* genekitr (NA)
51+
* ggh4x (NA)
52+
* glmmPen (NA)
53+
* grandR (NA)
54+
* immcp (NA)
55+
* loon.ggplot (NA)
56+
* MACP (NA)
57+
* MarketMatching (NA)
58+
* MARVEL (NA)
59+
* nlmixr2rpt (NA)
60+
* numbat (NA)
61+
* OlinkAnalyze (NA)
62+
* OpenMx (NA)
63+
* Platypus (NA)
64+
* PsychWordVec (NA)
65+
* RcppCensSpatial (NA)
66+
* rstan (NA)
67+
* RVA (NA)
68+
* rxode2 (NA)
69+
* SCpubr (NA)
70+
* tidySEM (NA)
71+
* tinyarray (NA)
72+
* valse (NA)
73+
* vivid (NA)

0 commit comments

Comments
 (0)