Skip to content

Commit 526a8d3

Browse files
authored
[go services]: workaround: disable grpc metrics (open-telemetry#1205)
* workaround: disable grpc metrics Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * workaround: disable grpc metrics Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
1 parent 3a00b49 commit 526a8d3

File tree

5 files changed

+345
-66
lines changed

5 files changed

+345
-66
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ release.
3939
([#1151](https://github.com/open-telemetry/opentelemetry-demo/pull/1151))
4040
* [opensearch] Add Grafana dashboard panels for OpenSearch log data
4141
([#1193](https://github.com/open-telemetry/opentelemetry-demo/pull/1193))
42+
* [go-sdk] Workaround: disable gRPC metrics in Go services
43+
([#1205](https://github.com/open-telemetry/opentelemetry-demo/pull/1205))
4244

4345
## 1.5.0
4446

src/checkoutservice/main.go

+5
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"context"
88
"encoding/json"
99
"fmt"
10+
"go.opentelemetry.io/otel/sdk/instrumentation"
1011
semconv "go.opentelemetry.io/otel/semconv/v1.19.0"
1112
"net"
1213
"net/http"
@@ -110,6 +111,10 @@ func initMeterProvider() *sdkmetric.MeterProvider {
110111
mp := sdkmetric.NewMeterProvider(
111112
sdkmetric.WithReader(sdkmetric.NewPeriodicReader(exporter)),
112113
sdkmetric.WithResource(initResource()),
114+
sdkmetric.WithView(sdkmetric.NewView(
115+
sdkmetric.Instrument{Scope: instrumentation.Scope{Name: "go.opentelemetry.io/contrib/google.golang.org/grpc/otelgrpc"}},
116+
sdkmetric.Stream{Aggregation: sdkmetric.AggregationDrop{}},
117+
)),
113118
)
114119
otel.SetMeterProvider(mp)
115120
return mp

src/productcatalogservice/go.mod

+21-23
Original file line numberDiff line numberDiff line change
@@ -5,39 +5,37 @@ go 1.17
55
require (
66
github.com/golang/protobuf v1.5.3
77
github.com/sirupsen/logrus v1.9.3
8-
golang.org/x/net v0.11.0 // indirect
9-
google.golang.org/grpc v1.56.1
8+
golang.org/x/net v0.17.0 // indirect
9+
google.golang.org/grpc v1.59.0
1010
)
1111

1212
require (
13-
go.opentelemetry.io/contrib/instrumentation/runtime v0.42.0
14-
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.39.0
15-
go.opentelemetry.io/otel/sdk v1.16.0
16-
go.opentelemetry.io/otel/sdk/metric v0.39.0
17-
go.opentelemetry.io/otel/trace v1.16.0
13+
go.opentelemetry.io/contrib/instrumentation/runtime v0.45.0
14+
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v0.42.0
15+
go.opentelemetry.io/otel/sdk v1.19.0
16+
go.opentelemetry.io/otel/sdk/metric v1.19.0
17+
go.opentelemetry.io/otel/trace v1.19.0
1818
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.3.0
19-
google.golang.org/protobuf v1.30.0
19+
google.golang.org/protobuf v1.31.0
2020
)
2121

2222
require (
2323
github.com/cenkalti/backoff/v4 v4.2.1 // indirect
24-
github.com/go-logr/logr v1.2.4 // indirect
24+
github.com/go-logr/logr v1.3.0 // indirect
2525
github.com/go-logr/stdr v1.2.2 // indirect
26-
github.com/grpc-ecosystem/grpc-gateway/v2 v2.16.0 // indirect
27-
go.opentelemetry.io/otel/exporters/otlp/internal/retry v1.16.0 // indirect
28-
go.opentelemetry.io/otel/exporters/otlp/otlpmetric v0.39.0 // indirect
29-
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.16.0 // indirect
30-
go.opentelemetry.io/otel/metric v1.16.0 // indirect
31-
go.opentelemetry.io/proto/otlp v0.20.0 // indirect
32-
google.golang.org/genproto/googleapis/api v0.0.0-20230530153820-e85fd2cbaebc // indirect
33-
google.golang.org/genproto/googleapis/rpc v0.0.0-20230530153820-e85fd2cbaebc // indirect
26+
github.com/grpc-ecosystem/grpc-gateway/v2 v2.18.0 // indirect
27+
go.opentelemetry.io/otel/exporters/otlp/otlpmetric v0.42.0 // indirect
28+
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.19.0 // indirect
29+
go.opentelemetry.io/otel/metric v1.19.0 // indirect
30+
go.opentelemetry.io/proto/otlp v1.0.0 // indirect
31+
google.golang.org/genproto/googleapis/api v0.0.0-20230822172742-b8732ec3820d // indirect
32+
google.golang.org/genproto/googleapis/rpc v0.0.0-20230822172742-b8732ec3820d // indirect
3433
)
3534

3635
require (
37-
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.42.0
38-
go.opentelemetry.io/otel v1.16.0
39-
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.16.0
40-
golang.org/x/sys v0.9.0 // indirect
41-
golang.org/x/text v0.10.0 // indirect
42-
google.golang.org/genproto v0.0.0-20230530153820-e85fd2cbaebc // indirect
36+
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.45.0
37+
go.opentelemetry.io/otel v1.19.0
38+
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.19.0
39+
golang.org/x/sys v0.13.0 // indirect
40+
golang.org/x/text v0.13.0 // indirect
4341
)

0 commit comments

Comments
 (0)