Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofit not working #22

Closed
mddanish00 opened this issue Feb 7, 2023 · 2 comments
Closed

Autofit not working #22

mddanish00 opened this issue Feb 7, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mddanish00
Copy link

Describe the bug
I specified autofit in my config but it was not reflected on the player. When opening the player, the player size same as the default. It is supposed to already be changed here like mpv. When loading a video, it also behaved the same. It ignored autofit-larger.

To Reproduce
Steps to reproduce the behavior:

  1. Add these lines to mpv.conf.
autofit-larger=75% # Set max window size.  height/width
autofit-smaller=858x480 # Set min window size.
  1. Open the player. See the size not changing.
  2. Load any video. See video size not changing automatically.

Expected behavior
The player follows autofit-larger and autofit-smaller like mpv. That means when loading video, the player has to be at least larger than 848x480 and cannot exceed the window width 75% of the screen size while keeping the aspect ratio.

Screenshots
If applicable, add screenshots to help explain your problem.
image
image

Environment (please complete the following information):

  • OS: Windows 10 Home
  • Version: 22H2
@mddanish00 mddanish00 added the bug Something isn't working label Feb 7, 2023
@tsl0922
Copy link
Owner

tsl0922 commented Feb 7, 2023

mpv's window related options need to be implemented on ImPlay window again, so not all of the options are supported now.

@tsl0922
Copy link
Owner

tsl0922 commented Feb 11, 2023

Closing as it's tracked in #27 now.

@tsl0922 tsl0922 closed this as completed Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants