From 19c6b20f8f79fda40f85b7e266ec124525616a4e Mon Sep 17 00:00:00 2001 From: Tom Payne Date: Sun, 30 Mar 2025 08:35:01 +0000 Subject: [PATCH] fix: Don't invoke pager with shell on Windows --- internal/cmd/config.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/cmd/config.go b/internal/cmd/config.go index 86528465d44..503b886a3e8 100644 --- a/internal/cmd/config.go +++ b/internal/cmd/config.go @@ -1402,11 +1402,11 @@ func (c *Config) getDiffPagerCmd() (*exec.Cmd, error) { return nil, nil } - // If the pager command contains any spaces, assume that it is a full - // shell command to be executed via the user's shell. Otherwise, execute - // it directly. + // If we're not on Windows and the pager command contains any spaces, assume + // that it is a full shell command to be executed via the user's shell. + // Otherwise, execute it directly. var pagerCmd *exec.Cmd - if strings.IndexFunc(pager, unicode.IsSpace) != -1 { + if runtime.GOOS != "windows" && strings.IndexFunc(pager, unicode.IsSpace) != -1 { shellCommand, _ := shell.CurrentUserShell() shellCommand, shellArgs, err := parseCommand(shellCommand, []string{"-c", pager}) if err != nil {