Inline _isBaseCellPentagon #984
Labels
Comments
ajfriend
added a commit
to ajfriend/h3
that referenced
this issue
Mar 9, 2025
ajfriend
added a commit
to ajfriend/h3
that referenced
this issue
Mar 9, 2025
Merged
ajfriend
added a commit
that referenced
this issue
Mar 10, 2025
* first real change * just for me * oooof clang format version thing? * fixed clang format * port over old new solution * try old * check that _isValidCell_const fails on draft PRs * try old again * ok, see if this passes * bah * everyone should like this one * who doesn't change their mind about comment formats? * playing * comment text * try inline * do you even bench? * confirm this works on my mac, but fails on other arch * some timings * timings * temporarily adding logs used to make plots * comment out _isValidCell_old * fail-fast: false * missed one! * try defined(_M_X64) * define some helper functions * more helpers * boop * notes * function names * move functions around * formatting * benchmarks * remove dev files * snake to camel * drop pos * drop some conditionals * intention more clear * organize * little nicer * remove justfile and remove fail fast * comment * bench for is base cell test * maybe working with extern * back to isBaseCellPentagonArr * TODO: #984 * changelog * remove files * remove more files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a follow-up for #968
As discussed in #968, it would be nice to inline
_isBaseCellPentagonfor use inisValidCell(and potentially other spots in the code base).I couldn't get this working in #968 after trying a mixture of
inlineandextern, so making this ticket to follow up and revisit.Some notes:
baseCellDataThe text was updated successfully, but these errors were encountered: