Update TaskWorkflowTemplate.create_task_workflow() method and unit test (#1339)

* Save Workflow instance in forward op to fix migration application

* Have TaskWorkflowTemplate.create_task_workflow() create summary task from data param

* Make explicit create_task_workflow() params

Author: dalecannon

tasks/migrations/0012_taskworkflow_assign_summary_task.py

@@ -12,7 +12,7 @@ def assign_new_summary_task_on_workflow(apps, schema_editor):
             title="Workflow summarising task",
             description="Workflow summarising task.",
         )
-        TaskWorkflow.save()
+        task_workflow.save()
 
 
 class Migration(migrations.Migration):

tasks/models/workflow.py

@@ -91,13 +91,13 @@ def get_task_templates(self) -> models.QuerySet:
         )
 
     @atomic
-    def create_task_workflow(self) -> "TaskWorkflow":
+    def create_task_workflow(self, title: str, description: str) -> "TaskWorkflow":
         """Create a workflow and it subtasks, using values from this template
         workflow and its task templates."""
 
+        summary_task = Task.objects.create(title=title, description=description)
         task_workflow = TaskWorkflow.objects.create(
-            title=self.title,
-            description=self.description,
+            summary_task=summary_task,
             creator_template=self,
         )
 

tasks/tests/test_workflow_models.py

@@ -13,20 +13,22 @@ def test_create_task_workflow_from_task_workflow_template(
 ):
     """Test creation of TaskWorkflow instances from TaskWorkflowTemplates using
     its `create_task_workflow()` method."""
+    title = "Workflow title"
+    description = "Workflow description"
     task_workflow = (
-        task_workflow_template_three_task_template_items.create_task_workflow()
+        task_workflow_template_three_task_template_items.create_task_workflow(
+            title=title,
+            description=description,
+        )
     )
 
     # Test that workflow values are valid.
     assert (
         task_workflow.creator_template
         == task_workflow_template_three_task_template_items
     )
-    assert task_workflow.title == task_workflow_template_three_task_template_items.title
-    assert (
-        task_workflow.description
-        == task_workflow_template_three_task_template_items.description
-    )
+    assert task_workflow.summary_task.title == title
+    assert task_workflow.summary_task.description == description
     assert task_workflow.get_items().count() == 3
 
     # Validate that item positions are equivalent.