Don't update queue positions if packaged workbasket is no longer a queue member

Author: dalecannon

publishing/models/packaged_workbasket.py

@@ -669,7 +669,7 @@ def promote_to_top_position(self) -> "PackagedWorkBasket":
         """Promote the instance to the top position of the package processing
         queue so that it occupies position 1."""
 
-        if self.position == 1:
+        if self.position <= 1:
             return self
 
         position = self.position
@@ -680,6 +680,7 @@ def promote_to_top_position(self) -> "PackagedWorkBasket":
 
         self.position = 1
         self.save()
+        self.refresh_from_db()
 
         return self
 
@@ -689,7 +690,7 @@ def promote_position(self) -> "PackagedWorkBasket":
         """Promote the instance by one position up the package processing
         queue."""
 
-        if self.position == 1:
+        if self.position <= 1:
             return
 
         obj_to_swap = PackagedWorkBasket.objects.select_for_update(nowait=True).get(
@@ -711,7 +712,7 @@ def demote_position(self) -> "PackagedWorkBasket":
         """Demote the instance by one position down the package processing
         queue."""
 
-        if self.position == PackagedWorkBasket.objects.max_position():
+        if self.position in {0, PackagedWorkBasket.objects.max_position()}:
             return
 
         obj_to_swap = PackagedWorkBasket.objects.select_for_update(nowait=True).get(