Skip to content

Reuse lint/parser infra for invalid keys error printing #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
samhh opened this issue Oct 31, 2022 · 1 comment
Open

Reuse lint/parser infra for invalid keys error printing #178

samhh opened this issue Oct 31, 2022 · 1 comment

Comments

@samhh
Copy link
Member

samhh commented Oct 31, 2022 •
edited
Loading

See #179.
@samhh
Copy link
Member Author

samhh commented Jan 19, 2023

This looks easier said than done.

We only parse and keep AST annotations/offsets for ICU messages themselves. The JSON is parsed as a quick conversion roughly Text -> Map.

The easiest route may be shifting this check into the JSON compiler, but then the JSON compiler needs to know about all the code compilers, and conditionally call them all depending on the backend value. This could get messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samhh