Limit on number of audio samples processed is hardcoded

[unvermuthet]

godot-ndi/src/video_stream_playback_ndi.cpp

Line 178 in b82df26

int processed_samples = Math::min(audio_frame.no_samples, 4096); // FIXME: dont hardcode this

This line of code clamps the number of processed samples to 4096. Pass too many samples to mix_audio and the following error is triggered. Note that 4096 refers to number of Float32 samples per audio channel.

gERROR: Condition "p_frames >= rb_len" is true.
   at: write (./servers/audio/audio_rb_resampler.h:119)

The max number of samples shouldn’t be hardcoded because it depends on the size of the audio buffer. Which audio buffer is unclear though. It could be related to the ms value in the Project settings under Audio Driver, it could be related to the „Buffering MSec“ value on the VideoStreamPlayer or it might even be limited by the buffer size on Godots Resampler. This would need some testing and engine code inspection, but the minimum between the first and second value mentioned might be a good start.

[unvermuthet]

The "Buffering Msec" property on the VideoStreamPlayer is inaccessible from inside the VideoStreamPlayerNDI Resource. Output latency value from ProjectSettings can be obtained thought.