Skip to content

Commit 26af7c8

Browse files
committed
ci: aarch64: increase test tolerance
1 parent 46ecfa2 commit 26af7c8

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

.github/automation/performance/benchdnn_comparison.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,15 @@ def compare_two_benchdnn(file1, file2, tolerance=0.05):
6262
r2_times = r2_samples[prb]
6363

6464
res = ttest_ind(r2_times, r1_times, alternative='greater')
65-
times[prb] = (statistics.median(r1_times), statistics.median(r2_times))
65+
r1_med = statistics.median(r1_times)
66+
r2_med = statistics.median(r2_times)
67+
times[prb] = (r1_med, r2_med)
6668
times_str = f" {times[prb][0]} vs {times[prb][1]}"
6769

68-
passed = True
69-
if res.pvalue < 0.05:
70+
passed = res.pvalue > 0.05 or \
71+
((r2_med - r1_med) / r1_med < 0.1 and \
72+
(min(r2_times) - min(r1_times)) / min(r1_times) < 0.1)
73+
if passed:
7074
failed_tests.append(prb + times_str)
7175
passed = False
7276

.github/workflows/performance-aarch64.yml

+5-3
Original file line numberDiff line numberDiff line change
@@ -157,13 +157,15 @@ jobs:
157157
env:
158158
DYLD_LIBRARY_PATH: ${{ github.workspace }}/ComputeLibrary/build
159159

160-
- name: Compare performance test results
161-
id: performance-test
160+
- name: Compare 16 threads performance test results
162161
run: |
163-
echo "16 threads:"
164162
python ${{ github.workspace }}/oneDNN/.github/automation/performance/benchdnn_comparison.py base.txt new.txt
165163
echo "fast math:"
166164
python ${{ github.workspace }}/oneDNN/.github/automation/performance/benchdnn_comparison.py base_fast.txt new_fast.txt
165+
166+
- name: Compare fast math performance test results
167+
run: |
168+
python ${{ github.workspace }}/oneDNN/.github/automation/performance/benchdnn_comparison.py base_fast.txt new_fast.txt
167169
168170
169171
#* This job adds a check named "Nightly Performance AArch64" that represents overall

0 commit comments

Comments
 (0)