Skip to content

Commit 2a89271

Browse files
committed
ci: aarch64: refactor fast math tests
1 parent 6f1a913 commit 2a89271

File tree

8 files changed

+28
-56
lines changed

8 files changed

+28
-56
lines changed

.github/automation/performance/bench_fast_math_performance.sh

-46
This file was deleted.

.github/automation/performance/benchdnn_comparison.py

+4
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,10 @@ def compare_two_benchdnn(file1, file2, tolerance=0.05):
6767
times[prb] = (r1_med, r2_med)
6868
times_str = f" {times[prb][0]} vs {times[prb][1]}"
6969

70+
# pass the test if:
71+
# the t-test passes (i.e. pvalue > 0.05) OR
72+
# both the median time and min time has not
73+
# slowed down by more than 10%
7074
passed = res.pvalue > 0.05 or \
7175
((r2_med - r1_med) / r1_med < 0.1 and \
7276
(min(r2_times) - min(r1_times)) / min(r1_times) < 0.1)

.github/automation/performance/inputs/conv

+6
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,9 @@
1919
--dir=FWD_D
2020
--dt=f32
2121
mb1_ic64oc256_ih200oh200kh1sh1dh0ph0_iw267ow267kw1sw1dw0pw0
22+
23+
--reset
24+
--dir=FWD_D
25+
--dt=f32
26+
--attr-fpmath=bf16
27+
mb1_ic64oc256_ih200oh200kh1sh1dh0ph0_iw267ow267kw1sw1dw0pw0

.github/automation/performance/inputs/conv_nightly

+1
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,5 @@
2121
--dt=f32
2222
--alg=auto
2323
--dir=FWD_D,FWD_B
24+
--attr-fpmath=,bf16
2425
--batch=shapes_resnet_50

.github/automation/performance/inputs/matmul

+9
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,16 @@
1717
--reset
1818
--stag=ab
1919
--wtag=any
20+
--dtag=ab
2021
--attr-post-ops=sum
22+
--dt=f32
23+
1500x1536:1536x384
24+
25+
--reset
26+
--stag=ab
27+
--wtag=any
2128
--dtag=ab
29+
--attr-post-ops=sum
30+
--attr-fpmath=bf16
2231
--dt=f32
2332
1500x1536:1536x384

.github/automation/performance/inputs/matmul_nightly

+8
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,14 @@
2626
--bia_mask=4
2727
--batch=shapes_3d
2828

29+
--dt=f32
30+
--bia-dt=f32,undef
31+
--bia_mask=2
32+
--attr-fpmath=bf16
33+
--batch=shapes_2d_ci
34+
--bia_mask=4
35+
--batch=shapes_3d
36+
2937
#f16
3038
--dt=f16:f16:f16
3139
--bia-dt=undef

.github/workflows/ci-aarch64.yml

-3
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,6 @@ jobs:
213213
run: |
214214
OMP_NUM_THREADS=4 bash ${{ github.workspace }}/oneDNN/.github/automation/performance/bench_pr_performance.sh ${{ github.workspace }}/oneDNN_base/build/tests/benchdnn/benchdnn ${{ github.workspace }}/oneDNN/build/tests/benchdnn/benchdnn base_4.txt new_4.txt
215215
OMP_NUM_THREADS=16 bash ${{ github.workspace }}/oneDNN/.github/automation/performance/bench_pr_performance.sh ${{ github.workspace }}/oneDNN_base/build/tests/benchdnn/benchdnn ${{ github.workspace }}/oneDNN/build/tests/benchdnn/benchdnn base_16.txt new_16.txt
216-
OMP_NUM_THREADS=16 bash ${{ github.workspace }}/oneDNN/.github/automation/performance/bench_fast_math_performance.sh ${{ github.workspace }}/oneDNN_base/build/tests/benchdnn/benchdnn ${{ github.workspace }}/oneDNN/build/tests/benchdnn/benchdnn base_fast.txt new_fast.txt
217216
env:
218217
DYLD_LIBRARY_PATH: ${{ github.workspace }}/ComputeLibrary/build
219218

@@ -226,8 +225,6 @@ jobs:
226225
python ${{ github.workspace }}/oneDNN/.github/automation/performance/benchdnn_comparison.py base_4.txt new_4.txt
227226
echo "16 threads:"
228227
python ${{ github.workspace }}/oneDNN/.github/automation/performance/benchdnn_comparison.py base_16.txt new_16.txt
229-
echo "fast math:"
230-
python ${{ github.workspace }}/oneDNN/.github/automation/performance/benchdnn_comparison.py base_fast.txt new_fast.txt
231228
232229
- name: Check performance test failure
233230
if: ${{ steps.performance-test.outputs.pass != 'True' && github.event_name == 'pull_request' && matrix.config.build == 'Release' && matrix.config.name != 'cb100' }}

.github/workflows/performance-aarch64.yml

-7
Original file line numberDiff line numberDiff line change
@@ -153,19 +153,12 @@ jobs:
153153
shell: bash
154154
run: |
155155
OMP_NUM_THREADS=16 bash ${{ github.workspace }}/oneDNN/.github/automation/performance/bench_nightly_performance.sh ${{ github.workspace }}/oneDNN_base/build/tests/benchdnn/benchdnn ${{ github.workspace }}/oneDNN/build/tests/benchdnn/benchdnn base.txt new.txt
156-
OMP_NUM_THREADS=16 bash ${{ github.workspace }}/oneDNN/.github/automation/performance/bench_fast_math_performance.sh ${{ github.workspace }}/oneDNN_base/build/tests/benchdnn/benchdnn ${{ github.workspace }}/oneDNN/build/tests/benchdnn/benchdnn base_fast.txt new_fast.txt
157156
env:
158157
DYLD_LIBRARY_PATH: ${{ github.workspace }}/ComputeLibrary/build
159158

160159
- name: Compare 16 threads performance test results
161160
run: |
162161
python ${{ github.workspace }}/oneDNN/.github/automation/performance/benchdnn_comparison.py base.txt new.txt
163-
164-
- name: Compare fast math performance test results
165-
if: success() || failure()
166-
run: |
167-
python ${{ github.workspace }}/oneDNN/.github/automation/performance/benchdnn_comparison.py base_fast.txt new_fast.txt
168-
169162
170163
#* This job adds a check named "Nightly Performance AArch64" that represents overall
171164
#* workflow status and can be used in branch rulesets

0 commit comments

Comments
 (0)