Skip to content

Commit 4a5582a

Browse files
committed
benchdnn: reorder: update filling for s32->f32 cases with zero-points
1 parent b5698d2 commit 4a5582a

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

tests/benchdnn/reorder/cfg.cpp

+5-4
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,11 @@ REG(f8_e5m2, -f16_max_exact, f16_max_exact);
4242
REG(f8_e4m3, -f16_max_exact, f16_max_exact);
4343
REG(f4_e2m1, -f16_max_exact, f16_max_exact);
4444
REG(f4_e3m0, -f4_max_exact, f4_max_exact);
45-
// Do not exceed max float value representable in integer. Otherwise, we get
46-
// a correctness issue caused by different computations in reference and the
47-
// library.
48-
REG(s32, INT_MIN, BENCHDNN_S32_TO_F32_SAT_CONST);
45+
// Do not exceed min/max float value representable in integer. Otherwise, we get
46+
// a correctness issue caused by different computations or roudings in the naive
47+
// reference and the library. One of those can be zero-point subtracting which
48+
// leads to underflow or overflow.
49+
REG(s32, -BENCHDNN_S32_TO_F32_SAT_CONST, BENCHDNN_S32_TO_F32_SAT_CONST);
4950
REG(s8, INT8_MIN, INT8_MAX);
5051
REG(u8, 0, UINT8_MAX);
5152
REG(s4, -7, 8);

0 commit comments

Comments
 (0)