Apply suggestions from code review

Co-authored-by: Dmitry Zarukin <dmitry.zarukin@intel.com>

Author: AD2605

src/gpu/generic/sycl/ref_reorder.hpp

@@ -99,7 +99,7 @@ struct ref_reorder_t : public gpu::generic::sycl::primitive_t {
 
         bool scales_ok() const {
             if (!attr()->scales_.has_default_values(
-                        DNNL_ARG_ATTR_SCALES | DNNL_ARG_FROM)) {
+                        DNNL_ARG_FROM)) {
                 // Check if scales are applied and then check the data type
                 // otherwise either data type can come up as data_type::undef
                 // returning false unecessarily

src/gpu/generic/sycl/reorder_kernels.hpp

@@ -44,9 +44,9 @@ struct reorder_kernel_t {
         , dst_scale_(
                   CTX_IN_SYCL_KERNEL_MEMORY(DNNL_ARG_ATTR_SCALES | DNNL_ARG_TO))
         , src_zero_points(CTX_IN_SYCL_KERNEL_MEMORY(
-                  DNNL_ARG_ATTR_ZERO_POINTS | DNNL_ARG_SRC))
+                  DNNL_ARG_ATTR_ZERO_POINTS | DNNL_ARG_FROM))
         , dst_zero_points(CTX_IN_SYCL_KERNEL_MEMORY(
-                  DNNL_ARG_ATTR_ZERO_POINTS | DNNL_ARG_DST))
+                  DNNL_ARG_ATTR_ZERO_POINTS | DNNL_ARG_TO))
         , scales_src_dt_(conf_.do_scale_src
                           ? ctx.memory_mdw(DNNL_ARG_ATTR_SCALES | DNNL_ARG_FROM)
                                     .data_type()

tests/benchdnn/reorder/reorder.cpp

@@ -356,10 +356,7 @@ void skip_unimplemented_prb(const prb_t *prb, res_t *res) {
         }
 
         // Skip blocked format tags and 4 bit formats for Nvidia/AMD/Generic SYCL backends
-        const auto &engine = get_test_engine();
-
-        if (is_generic_gpu(engine) || is_nvidia_gpu(engine)
-                || is_amd_gpu(engine)) {
+        if (is_generic_gpu()) {
             const bool is_4bit_format = is_nibble_sized_type(prb->sdt)
                     || is_nibble_sized_type(prb->ddt);