cpu: tidy: readability

Author: dzarukin

src/cpu/x64/jit_avx512_core_bf16cvt.hpp

@@ -288,6 +288,7 @@ struct jit_avx512_core_add_cvt_ps_to_bf16_t : public jit_generator_t {
 // it is required for quick implementation of 1x1 bf16 bwd_w jit kernel
 // w/o using permw instruction inside
 // TODO: consider modification/replacement for outer transformation jit kernel
+//NOLINTNEXTLINE(readability-identifier-naming)
 struct jit_avx512_core_bf16_reorder_s16c_to_S16c2s_t : public jit_generator_t {
     DECLARE_CPU_JIT_AUX_FUNCTIONS(jit_avx512_core_bf16_reorder_s16c_to_S16c2s)
 

src/cpu/x64/jit_brgemm_post_ops.hpp

@@ -113,7 +113,6 @@ struct jit_brgemm_kernel_diff_bias_t : public jit_generator_t {
     void init_masks(int tail_length);
     void generate() override;
 
-private:
     void horizontal_sum(Xbyak::Xmm src);
     void horizontal_sum(Xbyak::Ymm src, Xbyak::Ymm workspace);
     void horizontal_sum(Xbyak::Zmm src, Xbyak::Zmm workspace);
@@ -283,7 +282,7 @@ struct jit_brgemm_kernel_post_ops_t : public jit_brgemm_kernel_post_ops_base_t,
     }
 
     template <typename T>
-    const T maybe_mask(const T vmm_in, bool mask_flag, bool store,
+    T maybe_mask(const T vmm_in, bool mask_flag, bool store,
             Xbyak::Opmask ktail_mask) {
         assert(IMPLICATION(mask_flag, isa_has_masks(brg_.isa_impl)));
         return mask_flag

src/cpu/x64/rnn/brgemm_cell_common_fwd.hpp

@@ -1,5 +1,5 @@
 /*******************************************************************************
-* Copyright 2021-2024 Intel Corporation
+* Copyright 2021-2025 Intel Corporation
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
@@ -121,7 +121,6 @@ class brgemm_dst_proj_t {
 private:
     void kernel(const int ithr, const int nthr) const;
 
-private:
     const ref_rnn_brgemm_t &rnn_brgemm_;
     const rnn_utils::rnn_conf_t &rnn_;
     const int proj_desc_idx_;

src/cpu/x64/rnn/jit_uni_lstm_cell_postgemm.hpp

@@ -162,7 +162,6 @@ struct jit_uni_lstm_cell_postgemm_t {
         }
     }
 
-protected:
     const bool avx2_available_ = is_superset(isa, avx2);
 
 private:

src/cpu/x64/rnn/jit_uni_rnn_common_postgemm.hpp

@@ -69,9 +69,7 @@ struct jit_uni_rnn_postgemm : public jit_generator_t {
         , zmm_tail_k_mask(k3)
         , xf16_dq_reg_idx(tmp_vector_register_idx) {}
 
-    ~jit_uni_rnn_postgemm() override {
-        if (bf16_emu_) delete bf16_emu_;
-    }
+    ~jit_uni_rnn_postgemm() override { delete bf16_emu_; }
 
     bool is_projection() const { return projection_; };