Skip to content

Commit ba35ebc

Browse files
committed
xe: jit: address clang-tidy complaints
1 parent 4de3d44 commit ba35ebc

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

src/gpu/intel/jit/ir/core.hpp

+1
Original file line numberDiff line numberDiff line change
@@ -904,6 +904,7 @@ class ir_mutator_t {
904904
template <typename T>
905905
std::vector<T> mutate(const std::vector<T> &v) {
906906
std::vector<T> new_v;
907+
new_v.reserve(v.size());
907908
for (auto &e : v)
908909
new_v.push_back(mutate(e));
909910
return new_v;

src/gpu/intel/jit/ir/send_plan.cpp

+6-4
Original file line numberDiff line numberDiff line change
@@ -348,9 +348,11 @@ class tdim_info_t {
348348
tdim_info_t() = default;
349349
tdim_info_t(
350350
int tidx, const tdim_t &tdim, const view_t &view, int64_t block = 1)
351-
: tidx_(tidx), block_(block), dim_(&tdim) {
352-
base_mod_ = to_base(tdim, view.vvars());
353-
size_ = view.tlayout().dim(tidx);
351+
: tidx_(tidx)
352+
, size_(view.tlayout().dim(tidx))
353+
, base_mod_(to_base(tdim, view.vvars()))
354+
, block_(block)
355+
, dim_(&tdim) {
354356
for (dim_idx_t i = 0; i < tdim.nvargs(); i++) {
355357
vidxs_[i] = tdim.vidx(i);
356358
vstrides_[i] = tdim.vstride(i);
@@ -1822,10 +1824,10 @@ class view_iterator_t {
18221824
public:
18231825
view_iterator_t(const view_info_t &info)
18241826
: info_(info)
1827+
, inner_elems_(1)
18251828
, block_off_(nblocks())
18261829
, block_dims_(nblocks())
18271830
, off_(info.vlayout().ndims()) {
1828-
inner_elems_ = 1;
18291831
for (int i = 0; i < info_.inner_idx(); i++) {
18301832
inner_elems_ *= (int)blocks()[i].block;
18311833
}

src/gpu/intel/jit/reorder/reorder_kernel.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class reorder_kernel_t : public ir_kernel_t<hw> {
4949
const memory_desc_t *dst_md = (pd) ? pd->dst_md() : nullptr;
5050
set_kernel_iface(kernel_info.iface());
5151
reorder_ir_builder_t builder(cfg, kernel_info, attr, dst_md);
52-
stmt_t body = builder.stmt();
52+
const stmt_t &body = builder.stmt();
5353
setup_interface(body);
5454

5555
// Generate assembly from IR.

0 commit comments

Comments
 (0)